Modify ↓

Opened 17 years ago

Closed 17 years ago

#2535 closed defect (fixed)

[Patch] NPE if neither the specified icon nor no_icon.png can be found

Reported by: podolsir Owned by: team
Priority: minor Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

As of [1578], in case the icon image specified in the style file cannot be found and there's also no misc/no_icon.png file, the style XML reader still creates an IconElemStyle with the icon field set to null. If MapPaint then tries to paint the node with this style, it traps an NPE in MapPaintVisitor.drawNode.

Attachments (1)

missing-icon-npe.patch​ (1.5 KB ) - added by podolsir 17 years ago.
proposed solution: ignore the icon style spec if icon would be null

Download all attachments as: .zip

Change History (3)

by podolsir, 17 years ago

Attachment: missing-icon-npe.patch​ added

proposed solution: ignore the icon style spec if icon would be null

comment:1 by podolsir, 17 years ago

Summary: NPE if neither the specified icon nor no_icon.png can be found → [Patch] NPE if neither the specified icon nor no_icon.png can be found

comment:2 by stoecker, 17 years ago

Resolution: → fixed
Status: new → closed

In r1583.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.