Modify ↓

Opened 16 years ago

Closed 16 years ago

#2508 closed defect (wontfix)

[Patch]OsmPrimitive - realEqual - refactoring

Reported by: Gubaer Owned by: team
Priority: minor Milestone:
Component: Core Version: latest
Keywords: refactoring Cc: Gubaer

Description

I've been working on bugs related to conflict detection and conflict resolution and I felt that OsmPrimitive::realEqual would benefit from a minor refactoring - see attachement.

Attachments (1)

realEqual-refactoring.patch​ (2.3 KB ) - added by Gubaer 16 years ago.

Download all attachments as: .zip

Change History (5)

by Gubaer, 16 years ago

Attachment: realEqual-refactoring.patch​ added

comment:1 by Gubaer, 16 years ago

Cc: Gubaer added

comment:2 by stoecker, 16 years ago

Hmm, do you really think that is an improvement?

comment:3 by Gubaer, 16 years ago

yes.

I agree however that it doesn't fix a bug. Nor does it add functionality. So, it probably comes down to personal taste. I'll not get angry if you don't apply the patch ;-)

comment:4 by stoecker, 16 years ago

Resolution: → wontfix
Status: new → closed

Actually I prefer the single statement variant as the chances for the compiler to optimize it are much better. So this is a wontfix. Sorry :-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.