Changes between Version 1 and Version 2 of Ticket #24951, comment 1


Ignore:
Timestamp:
2026-10-11T17:34:58+02:00 (3 weeks ago)
Author:
wangi

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #24951, comment 1

    v1 v2  
    88==== #8464 grid
    99 * `MapFrame.gridOverlay`, `ShowTileBordersAction.layer` and `GridPreference.TranslatedRenderer.name` are now `transient` (S1948).
    10  * `AlignGridRotationAction.getSelectedDirection()` returns an empty array instead of `null` (S1168). The callers and `GridActionsTest` now check the length. This is the same change as #24949, but it also updates the other two `assertNull` checks on `getSelectedDirection()` in `GridActionsTest`. The #24949 patch only changes the first, so the test would fail with it.
     10 * `AlignGridRotationAction.getSelectedDirection()` returns a shared `EMPTY_DIRECTION` constant instead of `null` (S1168). The callers and `GridActionsTest` now check the length. This is the same change as #24949, and the constant is taken from that patch, thanks DanProgs. This patch also updates the other two `assertNull` checks on `getSelectedDirection()` in `GridActionsTest`. The #24949 patch only changes the first, so the test would fail with it.
    1111 * `GridPreference`: `GBC.HORIZONTAL`/`GBC.BOTH` → `GridBagConstraints.HORIZONTAL`/`BOTH` (S3252)
    1212 * `MapGridPaintable.getLatLonGridLines()`: the meridian loop is moved out into `addMeridian()`, to go with the existing `addParallel()`. This brings the cognitive complexity down from 19 to under 15 (S3776).
    … …  
    1515 * S1940 "use `<=`": the `!(x > 0)` checks were written that way on purpose so that NaN gets rejected too, and a plain `x <= 0` would let NaN through. They now call a small `isPositive()` helper in `MapGridPaintable`. In `GridPreference`, where the value is parsed from user input, the check is `Double.isNaN(value) || value <= 0`. The one in `addParallel()` never sees NaN, so it is simply `maxLon <= minLon`.
    1616
    17 There is no change in behaviour. `GridActionsTest`, `MapGridPaintableTest`, `ShowTileBordersActionTest`, `TileSourceDisplaySettingsTest`, `GridPreferenceTest` and `OsmConnectionTest` all pass, and checkstyle is clean.
     17There is no change in behaviour. `GridActionsTest`, `MapGridPaintableTest`, `ShowTileBordersActionTest`, `TileSourceDisplaySettingsTest`, `GridPreferenceTest` and `OsmConnectionTest` all pass, and checkstyle and `ant pmd` report nothing in the changed files.