support amenity=binoculars [PATCH]

[mkoniecz]

What steps will reproduce the problem?

1. create node
2. add amenity=binoculars to it

What is the expected result?

It has an icon

What happens instead?

Nothing

Please provide any additional information below. Attach a screenshot if possible.

It is in iD presets (that is how I found it, I have also some similar candidates and I can create tickets/patches if that would be welcome) - see ​https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/amenity/binoculars.json

iD presets have decent icon, using ​https://rapideditor.github.io/temaki/docs/#icon-temaki-binoculars which maybe can be reused

has some usage, 2k - see ​https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dbinoculars

I would add that preset for nodes only, like iD does

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2026-09-18 21:20:53 +0200 (Fri, 18 Sep 2026)
Revision:19625
Build-Date:2026-09-19 01:30:45
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19625 en) Linux Ubuntu 24.04.5 LTS
Memory Usage: 376 MB / 7996 MB (94 MB allocated, but free)
Java version: 21.0.12+8-1-24.04-Ubuntu, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920x1200x[Multi depth]@60Hz (scaling 1.00×1.00) :0.1 1920x1200x[Multi depth]@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: LXQt
Java package: openjdk-21-jre:amd64-21.0.12+8-1~24.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.40.0-3build2
libcommons-compress-java: libcommons-compress-java:all-1.25.0-1
libcommons-logging-java: libcommons-logging-java:all-1.3.0-1ubuntu1
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ reverter (36503)
+ todo (159)

Tagging presets:
+ ${HOME}/Documents/install_moje/OSM_software/josm/resources/data/defaultpresets.xml

Map paint styles:
+ ${HOME}/Documents/install_moje/OSM_software/josm/resources/styles/standard/elemstyles.mapcss

Last errors/warnings:
- 01137.024 E: Failed to locate image 'presets/leisure/binoculars.svg'
- 01145.509 E: Failed to locate image 'presets/leisure/binoculars.svg'
- 01147.007 E: Failed to locate image 'presets/leisure/binoculars.svg'
- 01147.062 E: Failed to locate image 'presets/leisure/binoculars.svg'
- 01148.580 E: Failed to locate image 'presets/leisure/binoculars.svg'
- 01148.625 E: Failed to locate image 'presets/leisure/binoculars.svg'
- 01148.636 E: Failed to locate image 'presets/leisure/binoculars.svg'
- 01149.046 E: Failed to locate image 'presets/leisure/binoculars.svg'
- 01252.787 E: Failed to locate image 'presets/leisure/binoculars.svg'
- 01252.787 E: Failed to locate image 'presets/leisure/binoculars.svg'

[mkoniecz]

also wonky patch

[mkoniecz]

this time icon is appearing but as a white square

for now I go to sleep, if idea for change would be accepted in general I will investigate what went wrong with the icon

[mkoniecz]

(this time JOSM was claiming that icon is not found but it has shown something at least... wtf?)

[mkoniecz]

also: fee/direction field may make sense?

[mkoniecz]

for other presets, from my initial triage:

amenity=device_charging_station
amenity=dog_toilet
amenity=dressing_room
amenity=give_box
amenity=karaoke_box
amenity=kneipp_water_cure
amenity=lavoir
amenity=loading_dock
amenity=luggage_locker
amenity=mortuary
amenity=motorcycle_rental
amenity=payment_centre
amenity=payment_terminal
amenity=post_depot
amenity=prep_school
amenity=refugee_site
amenity=ticket_validator
amenity=vacuum_cleaner
amenity=veterinary_pharmacy
amenity=waste_transfer_station
amenity=weighbridge

(if anyone is interested in taking deeper look and make patches/tickets/commits - feel free to steal ideas! If someone looked into some and for one reason or another makes no sense in JOSM - let me know and I will save time on investigating it myself)

[skyper]

See DevelopersGuide/DefaultPresets also for icons.
Especially, Styles/IconTester comes in handy to have a look at it with black background, some imagery and even white background using an overlay imagery background without transparency.

Replying to mkoniecz:

also: fee/direction field may make sense?

Yes, please, add useful combinations. The ​Tag:amenity=binoculars also mentions charge=*.
In general, common combinations are nice to have. Using <optional> can further categorize the combinations.

Regarding new tags, yet to silence the JOSM-Integration-Test is a never ending task.

[skyper]

Oh, amenity=binoculars is in Presets/NewTags. Unfortunately no icon and nothing to gain from there, though these few lines should be delete once a new tested version is released which includes this patch.