Modify ↓

Opened 3 weeks ago

Closed 9 days ago

Last modified 9 days ago

#24889 closed enhancement (fixed)

[PATCH] Add OpenGeofiction OAuth 2 client id

Reported by: wangi Owned by: team
Priority: normal Milestone: 26.09
Component: Core Version: latest
Keywords: template_report oauth Cc:

Description

What steps will reproduce the problem?

OpenGeofiction (​https://opengeofiction.net) runs the openstreetmap-website and CGImap stack for a fictional planet, with JOSM as one of its main editors. As for OpenHistoricalMap, a built-in client id lets 'Authorize now (Fully automatic)' work against its API; without it the button never enables for the host and users have to paste a server-minted token.

lugus.opengeofiction.net is the project's test server, sharing the id.

Patch attached, tested against production and test OGF instances.

What is the expected result?

Fully automatic authorisation flow.

What happens instead?

Jumping through manual hoops.

Please provide any additional information below. Attach a screenshot if possible.

Revision:19621
Is-Local-Build:true
Build-Date:2026-09-08 22:02:28

Identification: JOSM/1.5 (19621 SVN en_GB) Linux Ubuntu 26.04.1 LTS
Memory Usage: 374 MB / 3772 MB (106 MB allocated, but free)
Java version: 25.0.4+7-1-26.04-Ubuntu, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 3840x2400x[Multi depth]@60Hz (scaling 2.00×2.00)
Maximum Screen Size: 3840×2400
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_GB.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: ubuntu:GNOME
Java package: openjdk-25-jre:amd64-25.0.4+7-1~26.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.44.0-1
libcommons-logging-java: libcommons-logging-java:-
fonts-noto: fonts-noto:all-20201225-2build1
Dataset consistency test: No problems found

Plugins:
+ FastDraw (36503)
+ ImageIO (36483)
+ ImportImagePlugin (36503)
+ PicLayer (275)
+ apache-commons (36483)
+ continuosDownload (133)
+ ejml (36483)
+ geotools (36483)
+ jackson (36502)
+ jaxb (36483)
+ josmtiff (0.1.0)
+ jts (36483)
+ log4j (36483)
+ pbf (36493)
+ pmtiles (36503)
+ poly (36483)
+ reverter (36503)
+ undelete (36503)
+ utilsplugin2 (36503)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Potlatch2&zip=1
- ${HOME}/Dropbox/projects/osm/OGF-Cosperica/cosperica.mapcss
+ ${HOME}/Dropbox/projects/osm/boundaries.mapcss
- ${HOME}/Dropbox/projects/osm/city-survey.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://raw.githubusercontent.com/TommiContursi/MTB-TrailMap-JOSM-Style/main/MTB-Trailmap-JOSM-map-style.mapcss
+ ${HOME}/Dropbox/projects/osm/contours.mapcss

Last errors/warnings:
- 00001.191 W: Update plug-ins - You updated your JOSM software. To prevent problems the plug-ins should be updated as well.  Update plug-ins now?
- 00005.469 E: org.openstreetmap.josm.gui.mappaint.mapcss.parsergen.ParseException: Warning: end of line while reading an unquoted string at line 6 column 16.
- 00005.469 E: org.openstreetmap.josm.gui.mappaint.mapcss.parsergen.ParseException: Warning: end of line while reading an unquoted string at line 23 column 16.
- 00005.472 W: Initializing map style ${HOME}/Dropbox/projects/osm/boundaries.mapcss completed in 3 ms (2 errors, 0 warnings)

OSM API: https://lugus.opengeofiction.net/api

Attachments (1)

0001-Add-OpenGeofiction-OAuth-2-client-id.patch​ (1.7 KB ) - added by wangi 3 weeks ago.
patch to add OGF OAuth 2 client ID

Download all attachments as: .zip

Change History (5)

by wangi, 3 weeks ago

patch to add OGF OAuth 2 client ID

comment:1 by wangi, 3 weeks ago

Keywords: oauth added
Summary: Add OpenGeofiction OAuth 2 client id → [PATCH] Add OpenGeofiction OAuth 2 client id

comment:2 by stoecker, 2 weeks ago

Milestone: → 26.09

comment:3 by stoecker, 9 days ago

Resolution: → fixed
Status: new → closed

In 19627/josm:

fix #24890 - handle OAuth 2 against a server without a built-in client id - fix #24889 - add OAuthID for OpenGeofiction - patches by wangi

comment:4 by wangi, 9 days ago

thanks, appreciate it

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.