Modify ↓

Opened 7 weeks ago

Closed 3 weeks ago

#24858 closed defect (fixed)

Duplicate warning due to duplicated mapcss rule

Reported by: Famlam Owned by: team
Priority: normal Milestone: 26.09
Component: Core validator Version:
Keywords: template_report transformer Cc: francois.lacombe

Description (last modified by Famlam)

What steps will reproduce the problem?

  1. Validate ​https://www.openstreetmap.org/node/5847777765
  2. Get two identical warnings for this node

Origin

The following rules in JOSM's build-in rules exists twice in deprecated.mapcss, starting at lines 2338 and 2361

/* #20421 */
*[transformer=minor_distribution] {
  throwWarning: tr("{0} is deprecated", "{1.tag}");
  suggestAlternative: "transformer=distribution";
  group: tr("deprecated tagging");
  fixAdd: "transformer=distribution";
}

*[transformer=traction] {
  throwWarning: tr("{0} is deprecated", "{0.tag}");
  suggestAlternative: "transformer=main";
  group: tr("deprecated tagging");
  fixAdd: "transformer=main";
}

*[transformer=auto] {
  throwWarning: tr("{0} is deprecated", "{0.tag}");
  suggestAlternative: "transformer=* + windings:auto=yes";
  group: tr("deprecated tagging");
  fixRemove: "transformer";
  fixAdd: "windings:auto=yes";
}

The fix is probably simply removing these rules from one of the two locations.
The duplicated rule was added in r19591

Please provide any additional information below. Attach a screenshot if possible.

Revision:19613
Build-Date:2026-08-12 01:42:58

Identification: JOSM/1.5 (19613 nl) Windows 11 64-Bit
OS Build number: Windows 10 Home 25H2 (26200)
Memory Usage: 400 MB / 24368 MB (196 MB allocated, but free)
Java version: 21.0.12+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080x32bpp@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: nl_NL
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.19613, -XX:MaxRAMPercentage=75.0, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (36493)
+ imagery_offset_db (36503)
+ pt_assistant (684)
+ reverter (36503)
+ tageditor (36503)
+ turnlanes-tagging (1786514827)
+ utilsplugin2 (36503)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Potlatch2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.mappaint.mapcss

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/ChargeRules&zip=1
+ https://raw.githubusercontent.com/Famlam/OsmMapcssValidationNL/main/netherlands.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1
+ %UserProfile%\Documents\GitHub\osmose-backend\plugins\TagFix_MultipleTag2.validator.mapcss
+ %UserProfile%\Documents\GitHub\osmose-backend\plugins\TagFix_Destination.validator.mapcss
+ %UserProfile%\Documents\GitHub\osmose-backend\plugins\Structural.validator.mapcss
+ %UserProfile%\Documents\GitHub\osmose-backend\plugins\Power.validator.mapcss
+ %UserProfile%\Documents\GitHub\osmose-backend\plugins\Phone2.validator.mapcss
+ %UserProfile%\Documents\GitHub\osmose-backend\plugins\notprefix.validator.mapcss
+ %UserProfile%\Documents\GitHub\osmose-backend\plugins\Construction2.validator.mapcss
+ %UserProfile%\Documents\GitHub\osmose-backend\plugins\Colour.validator.mapcss
+ %UserProfile%\Documents\GitHub\osmose-backend\plugins\Bicycle.validator.mapcss
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.validator.mapcss

Last errors/warnings:
- 00000.321 W: extended font config - overriding 'filename.Malgun_Gothic=malgun.ttf' with 'MALGUN.TTF'
- 00000.322 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.323 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00000.700 E: java.security.KeyStoreException: Windows-ROOT not found. Oorzaak: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available

Attachments (0)

Change History (5)

comment:1 by francois.lacombe, 7 weeks ago

I confirm the duplicate, two /* #20421 */ sections exists in deprecated.mapcss.

The last should be removed, yes

comment:2 by Famlam, 7 weeks ago

Description: modified (diff)

comment:3 by Famlam, 7 weeks ago

Thanks! I've updated the first post to reflect that there are 3 duplicated rules indeed.

comment:4 by stoecker, 7 weeks ago

Milestone: → 26.09

comment:5 by gaben, 3 weeks ago

Resolution: → fixed
Status: new → closed

In 19623/josm:

fix #24858 - remove duplicated MapCSS rule

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.