Modify

Opened 4 weeks ago

Closed 3 weeks ago

#24841 closed defect (fixed)

Opening openingh.openstreetmap.de with plus-signs (+) in the opening_hours value produces incorrect results (pluses disappear)

Reported by: kbos@… Owned by: team
Priority: normal Milestone: 26.09
Component: Core Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Create or find an opening_hours tag with one or more plus signs in the value. (Either open-ended times or some form of variable_date) example: "Mo-Fr 10:00+" or "easter +49 days 08:00-17:00"
  2. right click the opening_hours tag
  3. click 'Open openingh.openstreetmap.de"

What is the expected result?

openingh.openstreetmap.de opening with a value containing plus-signs in the "value for „opening_hours“" block

What happens instead?

The pluses do not show up in the "value for „opening_hours“" block (they appear to be replaced with <space>). Creating an invalid syntax.

Please provide any additional information below. Attach a screenshot if possible.

Revision:19555
Build-Date:2026-03-30 09:42:59

Identification: JOSM/1.5 (19555 en) Windows 11 64-Bit
OS Build number: Windows 10 Home 25H2 (26200)
Memory Usage: 720 MB / 24368 MB (198 MB allocated, but free)
Java version: 21.0.10+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 2560x1600x32bpp@60Hz (scaling 1.25×1.25)
Maximum Screen Size: 2560×1600
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.19555, -XX:MaxRAMPercentage=75.0, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ Review.Changes (1.1.1)
+ buildings_tools (36474)
+ easypresets (1623509627)
+ libphonenumber (9.0.34)
+ phonenumber (1.2.0)
+ reltoolbox (36474)
+ todo (159)
+ turnrestrictions (36474)
+ undelete (36474)
+ utilsplugin2 (36497)

Tagging presets:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/NL.zip
+ <josm.pref>/EasyPresets.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/iD&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lit&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Power&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Schools&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/NL.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksAndFootways&zip=1
+ https://raw.githubusercontent.com/tordanik/direction-cones-style/refs/heads/main/direction-cones.mapcss

Validator rules:
+ https://raw.githubusercontent.com/Famlam/OsmMapcssValidationNL/main/netherlands.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/InvalidWebsiteProtocol&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingOpeningHours&zip=1

Last errors/warnings:
- 00000.476 W: extended font config - overriding 'filename.Malgun_Gothic=malgun.ttf' with 'MALGUN.TTF'
- 00000.479 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.480 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00001.047 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available

Attachments (0)

Change History (5)

comment:1 by stoecker, 4 weeks ago

Milestone: 26.09

Probably needs to be encoded as "%2B".

comment:2 by kbos@…, 4 weeks ago

Exactly this encoding was also mentioned in the OSM forum thread I started about this. https://community.openstreetmap.org/t/link-to-opening-hours-evaluation-tool-looses-when-using-variable-date

comment:3 by stoecker, 4 weeks ago

Resolution: fixed
Status: newclosed

In 19617/josm:

fix #24841 - proper encoding of URL parameters in Tag2Link

comment:4 by kbos@…, 3 weeks ago

Resolution: fixed
Status: closedreopened

If this fix should be in version 19613, then something went wrong or this is not the correct fix. Because the problem persists

comment:5 by stoecker, 3 weeks ago

Resolution: fixed
Status: reopenedclosed

As you can see, when reading the message, the fix is in r19617.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.