[patch] Get ToggleDialog Headers height to respect gui.scale

[dmitry.v.kiselev@…]

When use increased gui.scale for high dpi monitors toggle dialogs headers appears to be to small. Right now it's height is hard-coded to 20px.

Reading gui.scale and applying it to header height improves UX.

I have preliminary version of patch attached.

[dmitry.v.kiselev@…]

src path

[stoecker]

First: Do not make this a static variable. This prevents changing it on runtime.

Second: Make it configurable, I.e. make the value you calculate a default value to a hidden setting (find a nice name :-).

[Dmitry Kiselev <dmitry.v.kiselev@…>]

v2

[Dmitry Kiselev <dmitry.v.kiselev@…>]

Is that a step in the right direction?

Not sure if gui.scale as a fallback is ok or you want it gone completely

this.titleHeight = Config.getPref().getInt("toggledialog.titlebar.height", 
            (int)(20 * Config.getPref().getDouble("gui.scale", 1.0)));

[stoecker]

Yes. But make it a local variable (or a function or copy the single assignment line) which gets reevaluated each time. Prefs lookup is not a costly operation.

[Dmitry Kiselev <dmitry.v.kiselev@…>]

v3: Evaluate titlebar each time it's used

[Dmitry Kiselev <dmitry.v.kiselev@…>]

Updated, see "v3: Evaluate titlebar each time it's used" attachment