Modify

Opened 3 months ago

Closed 2 months ago

#24688 closed enhancement (fixed)

Add shop=games to internal preset

Reported by: Koreller Owned by: team
Priority: normal Milestone: 26.05
Component: Internal preset Version:
Keywords: template_report shop game Cc:

Description

Problem

I want to propose a render for the tag shop=games (https://wiki.openstreetmap.org/wiki/Tag:shop%3Dgames), because there is none today.

Proposal

Today in JOSM it look like this :
https://community-cdn.openstreetmap.org/uploads/default/original/3X/2/f/2fc0601b6d5bf417058c2d77c5960986d411fb71.png

I would propose this one :
https://community-cdn.openstreetmap.org/uploads/default/original/3X/b/3/b3734c78e37f63222260f7e895f133055237ab2c.png

(https://community.openstreetmap.org/t/render-for-shop-games-in-osm-carto-and-josm/141749)

Attachments (1)

fas-dice.svg (771 bytes ) - added by Koreller 2 months ago.
purple-dice-icon

Download all attachments as: .zip

Change History (10)

comment:1 by stoecker, 3 months ago

Well, do you have an SVG image (without background) for that which matches our licence?

comment:2 by gaben, 3 months ago

Component: Core mappaintInternal preset
Summary: Render for shop=games in JOSMAdd shop=games to internal preset

comment:3 by gaben, 3 months ago

Keywords: shop game added

by Koreller, 2 months ago

Attachment: fas-dice.svg added

purple-dice-icon

comment:4 by Koreller, 2 months ago

This icon is a derivation from here https://github.com/openstreetmap/iD/tree/8e843dd47402304592b9ca496472c3d31112c59c/svg/fontawesome (fas-dice) with a purple color (#AC39AC).
As explain here : https://github.com/openstreetmap/iD/tree/8e843dd47402304592b9ca496472c3d31112c59c (at the bottom, section "License") the "Font Awesome" is in CC-BY 4.0, so for my derivative work it's the same license !
Do this licence is okay with JOSM ?

comment:5 by stoecker, 2 months ago

Milestone: 26.05

comment:6 by stoecker, 2 months ago

Resolution: fixed
Status: newclosed

In 19558/josm:

support shop games in map, fix #24688

comment:7 by stoecker, 2 months ago

In 19559/josm:

support shop games in map (drop ignores), see #24688

comment:8 by gaben, 2 months ago

Resolution: fixed
Status: closedreopened

@stoecker do you like the attached icon? I think it's nice, just needs some tuning (e.g. viewbox).

Not sure about the licensing, so I'm not committing it to the repo.

comment:9 by stoecker, 2 months ago

Resolution: fixed
Status: reopenedclosed

In 19564/josm:

support shop games in map, add missing icon, fix #24688

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.