"shop=windows" should not be listed as a deprecated tag

[Mannivu]

What steps will reproduce the problem?

1. Create, edit or select a "shop=window" element
2. Start Validator

What is the expected result?

Validator should ignore it.

What happens instead?

"​shop=windows" is a well used and established tag, yet the Validator signals it as deprecated

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2025-08-31 14:19:57 +0200 (Sun, 31 Aug 2025)
Revision:19439
Build-Date:2025-09-02 01:30:58
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19439 en_GB) Linux Ubuntu 25.10
Memory Usage: 1322 MB / 1322 MB (327 MB allocated, but free)
Java version: 21.0.9+10-Ubuntu-125.10, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920x1080x[Multi depth]@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: it_IT.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: ubuntu:GNOME
Java package: openjdk-21-jre:amd64-21.0.9+10-1~25.10
Java ATK Wrapper package: libatk-wrapper-java:all-0.42.1-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ FixAddresses (36438)
+ OpeningHoursEditor (36438)
+ apache-commons (36438)
+ buildings_tools (36438)
+ continuosDownload (128)
+ gridify (38)
+ imagery_offset_db (36438)
+ mapwithai (839)
+ measurement (36438)
+ openqa (116)
+ pmtiles (36438)
+ pt_assistant (677)
+ reverter (36447)
+ rex (60)
+ tageditor (36438)
+ terracer (36438)
+ turnlanes (36438)
+ turnlanes-tagging (1746100629)
+ turnrestrictions (36458)
+ undelete (36438)
+ urbaneye3d (1.6.1)
+ utilsplugin2 (36438)
+ wikipedia (441)

Tagging presets:
+ https://cdn.jsdelivr.net/npm/name-suggestion-index@latest/dist/presets/nsi-josm-presets.min.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
+ https://raw.githubusercontent.com/tordanik/direction-cones-style/refs/heads/main/direction-cones.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Validator rules:
+ https://raw.githubusercontent.com/fansanelli/map-this-way/master/MapThisWay.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/ItalySpecific&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/InvalidWebsiteProtocol&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1

Last errors/warnings:
- 00140.446 E: Failed to locate image 'reset_camera'
- 00220.499 W: No default layer selected, choosing first layer.
- 00227.862 E: Invalid setting (Icon missing): org.openstreetmap.josm.plugins.fixAddresses.FixAddressesPreferences
- 03611.501 W: org.openstreetmap.josm.plugins.ohe.parser.TokenMgrError: Lexical error at line 1, column 74.  Encountered: 'P' (80),
- 03612.824 W: Disable opening hours editor:: org.openstreetmap.josm.plugins.ohe.gui.OheException: Error in the TimeValue. Cause: org.openstreetmap.josm.plugins.ohe.parser.TokenMgrError: Lexical error at line 1, column 74.  Encountered: 'P' (80),
- 05202.356 E: Invalid setting (Icon missing): org.openstreetmap.josm.plugins.fixAddresses.FixAddressesPreferences
- 05225.112 E: Invalid setting (Icon missing): org.openstreetmap.josm.plugins.fixAddresses.FixAddressesPreferences
- 05304.523 E: Invalid setting (Icon missing): org.openstreetmap.josm.plugins.fixAddresses.FixAddressesPreferences
- 05334.654 E: Invalid setting (Icon missing): org.openstreetmap.josm.plugins.fixAddresses.FixAddressesPreferences
- 05366.672 E: Invalid setting (Icon missing): org.openstreetmap.josm.plugins.fixAddresses.FixAddressesPreferences

[stoecker]

Well, 232 uses total worldwide is something else as "well used and established tag".

[Mannivu]

You're right, still it's a valid tagging scheme and the validator shouldn't propose to be change it to "craft=window_construction" (which is completely wrong, since not every windows vendor make windows).