Modify

Opened 3 weeks ago

Closed 3 days ago

Last modified 2 days ago

#24601 closed defect (fixed)

Tests on Java25 fail: Cannot invoke "org.apache.commons.jcs3.auxiliary.disk.block.BlockDiskKeyStore.reset()" because "this.keyStore" is null

Reported by: stoecker Owned by: team
Priority: normal Milestone: 26.03
Component: Core Version:
Keywords: Cc: taylor.smock

Description

org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJobTest and org.openstreetmap.josm.data.imagery.TMSCachedTileLoaderJobTest fail for Java >= 24.

Attachments (0)

Change History (13)

comment:1 by stoecker, 3 weeks ago

Cc: taylor.smock added

@taylor.smock:

Do you have an idea how to fix this? ATM I don't even know where to start looking.

comment:2 by taylor.smock, 3 weeks ago

I'll probably run the tests in an IDE with a breakpoint set on keyStore to see when/where it is set (Java 21) and then see why that particular code path is not taken in Java 25.

comment:3 by stoecker, 2 weeks ago

Milestone: 25.1026.01

Milestone renamed

comment:4 by stoecker, 2 weeks ago

Milestone: 26.0126.03

comment:5 by taylor.smock, 2 weeks ago

This appears to be a test pollution issue. At least partially. Which is going to make it a PITA to debug.

comment:6 by stoecker, 7 days ago

In 19494/josm:

see #24601 - it seems to be a bug in JCS which pops up by a different order of execution in Java 25 - ChatGPT proposes this workaround to enforce initialisation, let's try it

comment:7 by stoecker, 7 days ago

In 19495/josm:

see #24601 - Nope, didn't help - do I really need to setup a Java 25 to test without checkin?

comment:8 by stoecker, 7 days ago

On Windows it works also with Java 25 in the GitHub tests. Only MacOs and Unix fail.

comment:9 by stoecker, 5 days ago

Installed Java 25.0.2 on my openSUSE Tumbleweed system. No failure. Work with "mvn test" and "ant test".

comment:10 by stoecker, 3 days ago

I hoped component updates may help. Sadly not.

comment:11 by stoecker, 3 days ago

In 19515/josm:

see #24601 - use different cache names for different tests (may be executed in parallel)

comment:12 by stoecker, 3 days ago

Resolution: fixed
Status: newclosed

comment:13 by stoecker, 2 days ago

Yeah. CI JOSM build is green again!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.