"Crossing waterways" validator produces many false positives with waterway=fairway

[bugs@…]

What steps will reproduce the problem?

1. Run the validator where there is a major river with a waterway=fairway tag (example: the mouth of the Columbia River ​https://www.openstreetmap.org/search?query=columbia%20river#map=12/46.2301/-123.7327)

What is the expected result?

Fairways crossing other waterways do not create a warning. ​Fairways are navigational routes, and necessarily coexist with but don't follow the way for the river itself, resulting in many "crossings" that should not be flagged as issues.

What happens instead?

I get a large number of validation warnings for fairways crossing the river way

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2025-08-31 14:19:57 +0200 (Sun, 31 Aug 2025)
Revision:19439
Build-Date:2025-09-01 01:31:04
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19439 en) Linux Ubuntu 25.04
Memory Usage: 3360 MB / 24032 MB (1727 MB allocated, but free)
Java version: 21.0.9+10-Ubuntu-125.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920x1080x[Multi depth]@60Hz (scaling 1.00×1.00) :0.1 1080x1920x[Multi depth]@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1920
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Java package: openjdk-21-jre:amd64-21.0.9+10-1~25.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.40.0-3build2
libcommons-compress-java: libcommons-compress-java:all-1.27.1-2
libcommons-logging-java: libcommons-logging-java:all-1.3.0-1ubuntu1
fonts-noto: fonts-noto:all-20201225-2
VM arguments: [-Djosm.restart=true, -Djava.net.useSystemProxies=true, -XX:MaxRAMPercentage=75.0, -Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugins:
+ DirectDownload (36438)
+ ImageWayPoint (36438)
+ ImportImagePlugin (36438)
+ ShapeTools (e2b1469)
+ Tracks2Map (0.3.2)
+ alignways (36438)
+ apache-commons (36438)
+ buildings_tools (36438)
+ changeset-viewer (1746100587)
+ editgpx (36438)
+ ejml (36438)
+ geotools (36438)
+ imagery_offset_db (36438)
+ jackson (36438)
+ jaxb (36438)
+ jogl (1.2.3)
+ jts (36438)
+ kendzi3d (1.0.205)
+ kendzi3d-resources (0.0.2)
+ log4j (36438)
+ lwjgl (36438)
+ lwjgl-unixoid (36438)
+ openvisible (36438)
+ reverter (36447)
+ tageditor (36438)
+ turnlanes-tagging (1746100629)
+ utilsplugin2 (36438)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Bus_lanes&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/US.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/TurnLanes&zip=1
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/BuildingPreset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Radwege&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Quick-highways&zip=1
+ https://osmtools.de/josm/steps.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&zip=1
- /home/joel/Projects/JOSM/Styles_Enhanced_Lane_and_Road_Attributes-style.mapcss
- https://raw.githubusercontent.com/OpenSidewalks/OpenSidewalks-Schema/master/open_sidewalks.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/Noname&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&zip=1
+ /home/joel/Projects/JOSM/Lane and Road Attributes/Styles_Lane_and_Road_Attributes-style.mapcss

Last errors/warnings:
- 08276.676 E: Bad Request - <html>The OSM server 'api.openstreetmap.org' reported a bad request.<br><br>The area you tried to download is too big or your request was too large.<br>Either request a smaller area or use an export file provided by the OSM community.<br><br>Downloading a smaller area is <em>recommended</em>!<br><br>Advanced users can use one of the following options:<br><ul><li><a href="https://josm.openstreetmap.de/wiki/Help/Action/Download#DownloadfromOverpassAPI">Overpass</a></li><li><a href="https://www.geofabrik.de/data/download.html">Geofabrik</a></li><li><a href="https://planet.openstreetmap.org/">OSM Planet File</a></li></ul></html>
- 08644.293 W: java.net.SocketException: Socket closed. Cause: java.net.SocketException: Socket closed
- 08644.293 E: java.net.SocketException: Socket closed. Cause: java.net.SocketException: Socket closed
- 08644.293 W: org.openstreetmap.josm.io.OsmTransferCanceledException: Operation canceled. Cause: org.openstreetmap.josm.io.OsmTransferException: Could not connect to the OSM server. Please check your internet connection.. Cause: java.net.SocketException: Socket closed. Cause: java.net.SocketException: Socket closed
- 08892.449 E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<You requested too many nodes (limit is 50000). Either request a smaller area, or use planet.osm>
- 08892.459 E: Bad Request - <html>The OSM server 'api.openstreetmap.org' reported a bad request.<br><br>The area you tried to download is too big or your request was too large.<br>Either request a smaller area or use an export file provided by the OSM community.<br><br>Downloading a smaller area is <em>recommended</em>!<br><br>Advanced users can use one of the following options:<br><ul><li><a href="https://josm.openstreetmap.de/wiki/Help/Action/Download#DownloadfromOverpassAPI">Overpass</a></li><li><a href="https://www.geofabrik.de/data/download.html">Geofabrik</a></li><li><a href="https://planet.openstreetmap.org/">OSM Planet File</a></li></ul></html>
- 10869.314 E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<You requested too many nodes (limit is 50000). Either request a smaller area, or use planet.osm>
- 10869.320 E: Bad Request - <html>The OSM server 'api.openstreetmap.org' reported a bad request.<br><br>The area you tried to download is too big or your request was too large.<br>Either request a smaller area or use an export file provided by the OSM community.<br><br>Downloading a smaller area is <em>recommended</em>!<br><br>Advanced users can use one of the following options:<br><ul><li><a href="https://josm.openstreetmap.de/wiki/Help/Action/Download#DownloadfromOverpassAPI">Overpass</a></li><li><a href="https://www.geofabrik.de/data/download.html">Geofabrik</a></li><li><a href="https://planet.openstreetmap.org/">OSM Planet File</a></li></ul></html>
- 13900.825 E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<You requested too many nodes (limit is 50000). Either request a smaller area, or use planet.osm>
- 13900.830 E: Bad Request - <html>The OSM server 'api.openstreetmap.org' reported a bad request.<br><br>The area you tried to download is too big or your request was too large.<br>Either request a smaller area or use an export file provided by the OSM community.<br><br>Downloading a smaller area is <em>recommended</em>!<br><br>Advanced users can use one of the following options:<br><ul><li><a href="https://josm.openstreetmap.de/wiki/Help/Action/Download#DownloadfromOverpassAPI">Overpass</a></li><li><a href="https://www.geofabrik.de/data/download.html">Geofabrik</a></li><li><a href="https://planet.openstreetmap.org/">OSM Planet File</a></li></ul></html>

[GerdP]

Can we really simply ignore all types of crossings? For examply, what if a waterway=fairway crosses a natural=water+water=river area or natural=coastline?

My current thinking:

• We should ignore two crossing waterway=fairway and a fairway crossing a linear waterway (river,stream,canal,drain,ditch)
• We should flag a waterway=fairway line crossing a natural=coastline or a natural=water

While looking at this I noticed that we don't warn about a waterway=river crossing a natural=water+water=river area. I have to find out if this is intended or not.

[GerdP]

See #20352. So for real waterways it is intended. What about waterway=fairway?