Modify

Opened 3 months ago

Last modified 2 months ago

#24456 new enhancement

[PATCH] Power circuits relations presets and validation

Reported by: francois.lacombe Owned by: team
Priority: normal Milestone: 25.10
Component: Core validator Version:
Keywords: power, circuits, routing, route Cc: stoecker, Klumbumbus

Description

Dear all,

Recently, and after several years of improvements, power=circuits has been reviewed and approved.
https://wiki.openstreetmap.org/wiki/Proposal:Power_circuits_routing

I encourage to use relations to map power circuits over physical level of power segments (line, cable, minor_line...).
It's a robust solution to avoid values lists in some keys like frequency as mentioned in #22633 and #22915.

Currently in JOSM, discouraged tagging with type=route + route=power is part of presets.
It should be move to a new category and replaced with type=power + power=circuits relations with same tagging completed with new topology{linear,branched} key.
https://wiki.openstreetmap.org/wiki/Tag:power%3Dcircuit
https://wiki.openstreetmap.org/wiki/Key:topology
wires=* key should not be used on power=circuit relations.

Roles are also changing. A power circuits expects substation and section as roles instead of substation and line.

It is possible to create relations involving discontinued lines as some segments may be missing at the moment at which the mapper intends to link two substations.
https://www.openstreetmap.org/relation/19536763

Finally, as per https://wiki.openstreetmap.org/wiki/Proposal:Power_circuits_routing#Less_tagging_redundancy_between_lines,_sections_and_circuits, a validation warning should be raised when both power=line and power=circuit relation it may be member of expose frequency=*. This information should be on relation only.

Best regards

Attachments (1)

josm_24456_24457.patch (11.2 KB ) - added by francois.lacombe 2 months ago.
Minor fixes in this patch (missing frequency in tag selector)

Download all attachments as: .zip

Change History (6)

comment:1 by francois.lacombe, 3 months ago

Code that covers most of this ticket is available here, I will investigate shortly about providing a diff to be integrated directly in josm
https://github.com/open-energy-transition/validate-my-grid/commit/965f472f64e94bde1e10db5b0521724fd7598417

comment:2 by francois.lacombe, 3 months ago

Cc: stoecker Klumbumbus added

comment:3 by francois.lacombe, 3 months ago

I hope everything is fine with the provided patch, that's my first contribution to JOSM source.
Feel free to advise me for any required fix

comment:4 by stoecker, 3 months ago

Milestone: 25.09
Summary: Power circuits relations presets and validation[PATCH] Power circuits relations presets and validation

by francois.lacombe, 2 months ago

Attachment: josm_24456_24457.patch added

Minor fixes in this patch (missing frequency in tag selector)

comment:5 by stoecker, 2 months ago

Milestone: 25.0925.10

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to francois.lacombe.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.