Modify ↓
Opened 3 months ago
Last modified 3 months ago
#24425 new defect
Insufficient validation of unclosed multipolygons
| Reported by: | Merle Moqueur | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core | Version: | |
| Keywords: | template_report | Cc: |
Description
What steps will reproduce the problem?
- Download data from an area so that some but not all the ways of a given multipolygon are downloaded
- Create an open way (even totally detached from the already loaded ways) in the area
- Give the "outer" (for example) role to the open way
- Upload the data
What will *not* reproduce the problem?
Download all the relationship from the beginning or download the missing ways after the initial download to make the edit.
What is the expected result?
Validation should fail because one or more edited nodes aren't attached to other nodes of the multipolygon or just because the multipolygon isn't closed (open segment overlapping part of a closed polygon for example).
What happens instead?
After only a warning about updating an incomplete relationship, validation succeeds, the data is sent to the server, and the rendering of the multipolygon isn't properly done (empty surface)
Please provide any additional information below. Attach a screenshot if possible.
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2024-12-02 20:14:56 +0100 (Mon, 02 Dec 2024) Revision:19265 Build-Date:2024-12-03 02:30:34 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (19265 fr) Linux Ubuntu 22.04.4 LTS Memory Usage: 1080 MB / 11712 MB (149 MB allocated, but free) Java version: 21.0.8+9-Ubuntu-0ubuntu122.04.1, Ubuntu, OpenJDK 64-Bit Server VM Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel Screen: :0.0 2560x1440x[Multi depth]@60Hz (scaling 1.00×1.00) Maximum Screen Size: 2560×1440 Best cursor sizes: 16×16→16×16, 32×32→32×32 Environment variable LANG: fr_FR.UTF-8 System property file.encoding: UTF-8 System property sun.jnu.encoding: UTF-8 Locale info: fr_FR Numbers with default locale: 1234567890 -> 1234567890 Desktop environment: ubuntu:GNOME Java package: openjdk-21-jre:amd64-21.0.8+9~us1-0ubuntu1~22.04.1 Java ATK Wrapper package: libatk-wrapper-java:all-0.38.0-5build1 fonts-noto: fonts-noto:all-20201225-1build1 VM arguments: [--module-path=/usr/share/openjfx/lib, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, -Djosm.restart=true, -Djava.net.useSystemProxies=true, -XX:MaxRAMPercentage=75.0, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED] Dataset consistency test: No problems found Plugins: + PicLayer (1.0.3) + PolygonCutOut (v0.7.3) + apache-commons (36349) + cadastre-fr (36344) + ejml (36348) + geotools (36349) + jackson (36349) + jaxb (36349) + jts (36349) Last errors/warnings: - 00001.278 W: Mettre à jour - La dernière mise à jour des greffons date de plus de 223 jours. - 12658.509 W: Modifications non enregistrées - <html>La relation a été modifiée.<br><br>Voulez-vous enregistrer vos modifications ?</html> - 12666.239 W: Modifications non enregistrées - <html>La relation a été modifiée.<br><br>Voulez-vous enregistrer vos modifications ?</html>
Attachments (0)
Note:
See TracTickets
for help on using tickets.
I think you get a warning that you modified an incomplete multipolygon relation. Isn't that enough?