Relationeditor map sync broken

[dieterdreist]

What steps will reproduce the problem?

1. open a relation in the relation editor
2. split a member way or remove the relation membership via "delete" in the tags panel

What is the expected result?

The map and relation editor get out of sync and the update-relation-in-the-editor-button in the relation editor becomes active

What happens instead?

It does not get active, and if you delete the membership via the tag panel, it asks for deletion but even after confirmation it does not actually remove it. Just close and reopen the relation editor and it is still there (also reappearing in the tags panel). Similarly, for way splits it misbehaves (I think it keeps the old id and does not add the new id, and does not give the correct warning and if the relation was displayed as a closed ring before the split, it will display as linear object after the split.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2025-07-21 17:04:22 +0200 (Mon, 21 Jul 2025)
Revision:19431
Build-Date:2025-07-22 01:30:38
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19431 en) FreeBSD
Memory Usage: 672 MB / 14336 MB (218 MB allocated, but free)
Java version: 21.0.7+6-1, OpenJDK BSD Porting Team, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920x1080x[Multi depth]@60Hz (scaling 1.00×1.00) :0.1 1920x1080x[Multi depth]@[Unknown refresh rate] (scaling 1.00×1.00) :0.2 1920x1080x[Multi depth]@[Unknown refresh rate] (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: XFCE
VM arguments: [--add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, -Djosm.home=<josm.pref>, -Dsun.java2d.opengl=true]
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (36438)
+ changeset-viewer (1746100587)
+ measurement (36438)
+ reverter (36447)
+ undelete (36438)

Last errors/warnings:
- 00283.110 W: java.io.IOException: Attribution is not loaded yet
- 00283.110 W: java.io.IOException: Attribution is not loaded yet
- 00283.110 W: java.io.IOException: Attribution is not loaded yet
- 00283.111 W: java.io.IOException: Attribution is not loaded yet
- 00283.111 W: java.io.IOException: Attribution is not loaded yet
- 00283.112 W: java.io.IOException: Attribution is not loaded yet
- 00283.112 W: java.io.IOException: Attribution is not loaded yet
- 00283.113 W: java.io.IOException: Attribution is not loaded yet
- 00283.114 W: java.io.IOException: Attribution is not loaded yet
- 05271.102 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out

[GerdP]

Possibly a regression from #21840.

[GerdP]

See my comments in #21840.

[GerdP]

simplify logic in isDirtyRelation(), don't return false if relationSnapshot has no dataset

[GerdP]

In 19432/josm:

fix #24423: Relationeditor map sync broken

• with #21840 some actions automatically update an open relation editor window if the relation is in sync with the dataset, else a notification about a pending conflict is shown. This logic was broken with r19402. This patch simplifies the logic in isDirtyRelation(): don't return false just because field relationSnapshot has no dataset.

[stoecker]

Milestone renamed

[GerdP]

Hmm, I fear I didn't test enough. Now I see too many notifications "Relation modified outside of relation editor with pending changes. Conflict resolution required.".