Modify ↓

Opened 4 months ago

Last modified 4 months ago

#24371 new defect

Validation of hiking route relations should not issue warnings for the roles forward and backward

Reported by: pelderson@… Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Add roles forward and backward to way members of a hiking|foot route relation, to map different routes for the two directions of travel.
  2. Then try uploading this, to trigger validation.

What is the expected result?

Validation of hiking route relations should not issue warnings for the roles forward and backward

What happens instead?

JOSM warns about unsupported roles forward and backward.

Please provide any additional information below. Attach a screenshot if possible.

For bicycle routes, roles backward and forward seem to be accepted without warnings.
Note that all recreational route relations should accept members with the roles forward, backward.

Revision:19412
Build-Date:2025-06-03 14:12:44

Identification: JOSM/1.5 (19412 nl) Windows 11 64-Bit
OS Build number: Windows 10 Home 24H2 (26100)
Memory Usage: 2208 MB / 12088 MB (1169 MB allocated, but free)
Java version: 21.0.7+6-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1200x32bpp@60Hz (scaling 1.25×1.25)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: nl_NL
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.19412, -XX:MaxRAMPercentage=75.0, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ ExtendedClipboard (1748770730)
+ PolygonCutOut (v0.7.3)
+ reltoolbox (36438)
+ todo (21c177b)
+ utilsplugin2 (36438)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/NumberedWalkingNodeNetworks&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&zip=1

Last errors/warnings:
- 48134.944 W: java.net.SocketTimeoutException: Connect timed out
- 48733.231 W: java.net.SocketTimeoutException: Connect timed out
- 48855.716 W: java.net.SocketTimeoutException: Connect timed out
- 51556.700 W: java.net.SocketTimeoutException: Connect timed out
- 51597.796 W: java.net.SocketTimeoutException: Connect timed out
- 55497.163 W: java.net.SocketTimeoutException: Connect timed out
- 55497.163 W: java.net.SocketTimeoutException: Connect timed out
- 55691.097 W: java.net.SocketTimeoutException: Connect timed out
- 55723.008 W: java.net.SocketTimeoutException: Connect timed out
- 57228.896 W: Niet-opgeslagen wijzigingen - <html>De relatie is gewijzigd.<br><br>Wilt u uw wijzigingen opslaan?</html>

Attachments (0)

Change History (1)

comment:1 by GerdP, 4 months ago

The default presets do not coontain the roles forward backward for hiking routes.
This patch would fix it:

  • defaultpresets.xml

     
    581581    <chunk id="walking_routes_roles">
    582582        <roles>
    583583            <role key="" text="route segment" requisite="required" type="way,closedway,relation" member_expression="highway|route=ferry" />
     584            <role key="forward" text="forward segment" requisite="optional" type="way,closedway" member_expression="highway|route=ferry|leisure=track" />
     585            <role key="backward" text="backward segment" requisite="optional" type="way,closedway" member_expression="highway|route=ferry|leisure=track" />
    584586            <role key="alternative" text="alternative segment" requisite="optional" type="way,closedway,relation" member_expression="highway|route=ferry" />
    585587            <role key="approach" text="approach segment" requisite="optional" type="way,closedway,relation" member_expression="highway|route=ferry" />
    586588            <role key="excursion" text="excursion segment" requisite="optional" type="way,closedway,relation" member_expression="highway|route=ferry" />

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to pelderson@….
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.