allow to disable filtering in the tags window

[dieterdreist]

I continuously get problems with the tags window, because when I hit "alt+a" to add a new tag, or "s" to switch to selection, instead the tags window had focus and adds a filter. Sometimes I do not see the tiny "s" or "å" in the filter fields, and do not recognized there are more tags on the object than those that I see.
Frankly, I never wanted to filter tags and I find the idea harmful, one should look at all tags when editing an object. Please give us an opt out at least, because it gets so often in the way.

[GerdP]

I cannot reproduce the problem, but you can disable the filter in the tags windows:
Set properties.filter.visable to false and restart JOSM.

[dieterdreist]

is it really

properties.filter.visable

or maybe

properties.filter.visible

?

I tried both but the filter line remains in the tags window. I attached now a screenshot which shows the part I am writing about (to avoid a misunderstanding). Btw.: how can I remove custom settings which I have added myself?

[dieterdreist]

filter line in tags window

[dieterdreist]

I think shortcut related behaviour may depend on the specific OS and java, I am on MacOS here. To illustrate this: on another machine which is running on FreeBSD, I found that ALT+click in refine mode (w) does not delete nodes (it does nothing) because the FreeBSD window manager uses "ALT" + drag to move windows (it is mostly unrelated to the issue here, but shows that the same keys and settings may behave differently on different systems).

[stoecker]

Replying to GerdP:

I cannot reproduce the problem, but you can disable the filter in the tags windows:
Set properties.filter.visable to false and restart JOSM.

Hmm, there is no code for such a key (yet).

src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java

@@ -823 +823 @@
 
         tagTable.setVisible(hasTags);
         tagTable.getTableHeader().setVisible(hasTags);
-        tagTableFilter.setVisible(hasTags);
+        boolean filterVisible = Config.getPref().getBoolean("properties.filter.visible", true);
+        tagTableFilter.setVisible(hasTags && filterVisible);
         selectSth.setVisible(!hasSelection);
         pluginHook.setVisible(hasSelection);
     }

[GerdP]

~Hm, I tried the option with r19334 and it works (with the typo "visable"), but only after a restart.~
Sorry, nonsense. This old preference was still in my settings and it has no function. Don't know what I tested, seems I didn't select any object.

[stoecker]

In 19413/josm:

see #24342 - add properties.filter.visible hidden setting