Opened 4 days ago
#24337 new enhancement
Validator: add AT:city_limit* and AT:shared_zone* to source:maxspeed
Reported by: | wolfbert | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core validator | Version: | |
Keywords: | template_report | Cc: |
Description
What steps will reproduce the problem?
- Run validator on a highway with "source:maxspeed" equal to either "AT:city_limit*" (*= 30 or 40) or "AT:shared_zone*" (*= 20 or 30)
What is the expected result?
Pass
What happens instead?
Error "unknown source:maxspeed context", see screenshot.
Please provide any additional information below. Attach a screenshot if possible.
Implicit values AT:city_limit* (city wide speed limit declared next to city limit sign) and AT:shared_zone* (living street with drive through permission, "Begegnungszone") are documented and in use in Austria.
These values are also valid for "maxspeed:type" but do not cause an error there, so probably aren't checked.
The place to change this seems to be https://github.com/JOSM/josm/blob/0d2fdfde57fad2f7c6946a837a8c083405d2b79e/src/org/openstreetmap/josm/data/validation/tests/Highways.java#L61 KNOWN_SOURCE_MAXSPEED_CONTEXTS.
While there, please also add contexts for zone(:)50 and zone(:)70.
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2025-05-01 13:38:02 +0200 (Thu, 01 May 2025) Revision:19396 Build-Date:2025-05-02 01:30:34 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (19396 de) Windows 10 64-Bit OS Build number: Windows 10 Pro 22H2 (19045) Memory Usage: 390 MB / 2048 MB (185 MB allocated, but free) Java version: 17.0.9+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel Screen: \Display0 2560x1440x32bpp@60Hz (scaling 1.25×1.25) Maximum Screen Size: 2560×1440 Best cursor sizes: 16×16→32×32, 32×32→32×32 System property file.encoding: Cp1252 System property sun.jnu.encoding: Cp1252 Locale info: de_AT Numbers with default locale: 1234567890 -> 1234567890 Dataset consistency test: No problems found Plugins: + ImportImagePlugin (36438) + Mapillary (1792) + PicLayer (266) + apache-commons (36438) + austriaaddresshelper (1727789616) + ejml (36438) + geotools (36438) + imagery_offset_db (36438) + jackson (36438) + jaxb (36438) + jts (36438) + measurement (36438) + opendata (36440) + reltoolbox (36438) + reverter (36438) + tageditor (36438) + turnlanes-tagging (1746100629) + turnrestrictions (36438) + utilsplugin2 (36438) Map paint styles: - https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1 - https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss Last errors/warnings: - 00000.448 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF' - 00000.449 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
Error message