Wrong status referrers-not-all-downloaded for restriction relation, Warning message when trying to delete

[GerdP]

What steps will reproduce the problem?

1. Start JOSM
2. download (restriction) relation 2234310
3. zoom to area that contains all mmembers of the relation
4. open new data layer and press Ctrl+Shift+Down to download data
5. select tab Download from OSM and click download
6. select the relation 2234310 and press Ctrl+I to show information
7. try to delete the relation

What is the expected result?

Step 6 should show State : all-referrers-downloaded
Step 7 should not popup "You are about to delete relations which can have other referrers not yet downloaded. This can cause problems ..."

What happens instead?

Step 6 shows State : referrers-not-all-downloaded
Step 7 shows the wrong popup "You are about to delete relations which can have other referrers not yet downloaded. This can cause problems ..."

Please provide any additional information below. Attach a screenshot if possible.

I have to use action "Download parent ways/relations" to actually change the status to all-referrers-downloaded
It seems that this happens with all kinds of releations, pronbably the Download data action doesn't set the flag for them? No idea if this is a new problem or one that exists since the flag FLAG_ALL_REFERRERS_DOWNLOADED was introduced with r19078.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2025-05-01 13:38:02 +0200 (Thu, 01 May 2025)
Revision:19396
Build-Date:2025-05-02 01:30:34
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19396 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 22H2 (19045)
Memory Usage: 347 MB / 1888 MB (159 MB allocated, but free)
Java version: 21.0.2+13-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080x32bpp@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.19039, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM HWConsole.exe]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (36438)
+ apache-commons (36438)
+ buildings_tools (36438)
+ comfort0 (36438)
+ ejml (36438)
+ geotools (36438)
+ jackson (36438)
+ jaxb (36438)
+ jts (36438)
+ o5m (36438)
+ opendata (36440)
+ pbf (36438)
+ poly (36438)
+ reltoolbox (36438)
+ reverter (36438)
+ terracer (36438)
+ undelete (36438)
+ utilsplugin2 (36438)

Tagging presets:
+ c:\josm\core\resources\data\defaultpresets.xml

Map paint styles:
+ c:\josm\core\resources\styles\standard\elemstyles.mapcss

Validator rules:
+ d:\java_tools\JOSM\mygeometry.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1
+ c:\josm\core\resources\data\validator\combinations.mapcss
+ c:\josm\core\resources\data\validator\geometry.mapcss

Last errors/warnings:
- 00391.976 W: java.io.IOException: Attribution is not loaded yet
- 00391.976 W: java.io.IOException: Attribution is not loaded yet
- 00391.977 W: java.io.IOException: Attribution is not loaded yet
- 00391.977 W: java.io.IOException: Attribution is not loaded yet
- 00391.979 W: java.io.IOException: Attribution is not loaded yet
- 00391.979 W: java.io.IOException: Attribution is not loaded yet
- 00391.980 W: java.io.IOException: Attribution is not loaded yet
- 00391.980 W: java.io.IOException: Attribution is not loaded yet
- 00391.982 W: java.io.IOException: Attribution is not loaded yet
- 00391.983 W: java.io.IOException: Attribution is not loaded yet

[GerdP]

OK, seems intented, a comment in BoundingBoxDownloader.java says

            // From https://wiki.openstreetmap.org/wiki/API_v0.6#Retrieving_map_data_by_bounding_box:_GET_/api/0.6/map,
            // relations are not recursed up, so they *may* have parent relations.
            // Nodes inside the download area should have all relations and ways that refer to them.
            // Ways should have all relations that refer to them and all child nodes, but those child nodes may not
            //    have their parent referrers.
            // Relations will have the *first* parent relations downloaded, but those are not split out in the returns.
            // So we always assume that a relation has referrers that need to be downloaded unless it has no child relations.

So, our problem is that we cannot distinguish between automatically downloaded parent relations and those which are completely inside the download area.

[GerdP]

Oops, didn't want to close.

[GerdP]

Nonsense! The last line in the comment block already says how to distinguish, there is just no code to do so.

[GerdP]

In 19406/josm:

fix #24315: Wrong status referrers-not-all-downloaded for restriction relation, Warning message when trying to delete
This adds code to set the flag for those relations in the downloaded area which have no child relations.