Modify

Opened 2 weeks ago

Last modified 4 days ago

#24276 new defect

Buildings not detected correctly when mapped with multipolygons

Reported by: BalooUriza Owned by: taylor.smock
Priority: normal Milestone:
Component: Plugin mapwithai Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Work on an area that has buildings mapped as multipolygon relations
  2. Load MapWithAI Data

What is the expected result?

Buildings should not be redetected as missing when mapped.

What happens instead?

Buildings mapped as a multipolygon instead get suggested for remapping as a simple closed way by MapWithAI

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2025-03-29 21:08:34 +0100 (Sat, 29 Mar 2025)
Revision:19369
Build-Date:2025-03-30 01:30:37
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19369 en) Linux Debian GNU/Linux 12 (bookworm)
Memory Usage: 4096 MB / 4096 MB (1001 MB allocated, but free)
Java version: 17.0.14+7-Debian-1deb12u1, Debian, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 3200x1080x[Multi depth]@50Hz (scaling 1.00×1.00) :0.1 1280x1024x[Multi depth]@[Unknown refresh rate] (scaling 1.00×1.00)
Maximum Screen Size: 3200×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: KDE
Java package: openjdk-17-jre:amd64-17.0.14+7-1~deb12u1
Java ATK Wrapper package: libatk-wrapper-java:all-0.40.0-3
fonts-noto: fonts-noto:all-20201225-1
VM arguments: [--module-path=/usr/share/openjfx/lib, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, -Djosm.restart=true, -Djava.net.useSystemProxies=true, -Dsun.java2d.ddforcevram=true, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED]
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (36413)
+ ColorPlugin (37)
+ FixAddresses (36413)
+ ImportImagePlugin (36413)
+ MapRoulette (62)
+ Mapillary (1792)
+ apache-commons (36415)
+ auto_tools (80)
+ buildings_tools (36413)
+ centernode (v1.0.4)
+ conflation (266)
+ continuosDownload (124)
+ easypresets (1623509627)
+ ejml (36415)
+ geotools (36413)
+ imagery_offset_db (36413)
+ intersection (0.0.7)
+ jackson (36415)
+ javafx (36415)
+ jaxb (36415)
+ josm-batch-downloader (1.0.4)
+ jts (36413)
+ mapwithai (837)
+ merge-overlap (36413)
+ notesolver (0.5.0)
+ opendata (36415)
+ openqa (113)
+ photo_geotagging (36413)
+ photoadjust (36413)
+ pmtiles (36415)
+ pt_assistant (654)
+ reltoolbox (36413)
+ routes (36413)
+ tageditor (36413)
+ terracer (36413)
+ todo (150)
+ turnlanes-tagging (1743059536)
+ turnrestrictions (36413)
+ uberterracer (1718729454)
+ utilsplugin2 (36413)
+ wikipedia (435)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/BicycleJunction&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Ghost%20Bike&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/MastAndTower&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NonMotorizedRoutes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParcelLockers&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Toll_Infrastructure&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/US.zip
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.xml
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Wikidata&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Radwege&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Power_Mapping_Utility_Simple&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/public_bookcase&zip=1
+ <josm.userdata>/EasyPresets.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Disc_Golf_Course&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/StreetCabinet&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/OpenSeaMap-PresetForSeamarks&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Healthcare&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportOneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportGtfs&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Surveillance&zip=1
+ https://raw.githubusercontent.com/katycat5e/OSM-US-Historic/main/us-historic-presets.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/DestinationSignRelation&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Direction&zip=1
+ https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Fixme&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/HighwayAreas&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleBuildingTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Bench&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/US.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/DiscGolfCourse&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/TigerReviewedNo&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapillaryDetections&zip=1

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/CheckDate&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingWeekdays&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/PublicTransportGtfs&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SourceObjectTag&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingOpeningHours&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/NotCheck&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/FacebookWebsite&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/QAToolInspiredValidations&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingStreetnumberOrConscriptionnumber&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/InvalidWebsiteProtocol&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/AddrFullWarning&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingMain&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/ThisOrThat&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/CountryCodeCheck&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/Runways&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1

Last errors/warnings:
- 09981.370 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 09982.093 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 09982.093 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 09982.527 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 09982.527 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 09983.273 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 09983.273 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 09995.961 W: java.net.NoRouteToHostException: No route to host
- 09995.961 W: java.net.NoRouteToHostException: No route to host
- 15560.598 W: java.lang.UnsupportedOperationException: The BROWSE action is not supported on the current platform!

Attachments (0)

Change History (3)

comment:1 by GerdP, 2 weeks ago

Component: CorePlugin mapwithai
Owner: changed from team to taylor.smock

comment:2 by taylor.smock, 4 days ago

The building conflation is done server-side.

I can look into doing building conflation client-side, but I am very short on time right now -- I'm starting a new job Monday.

Unfortunately, AFAIK, Meta is no longer working on the server-side portion, so that won't be fixed for both Rapid and JOSM. And the contract devs for both Rapid (Bryan and Tanner) and JOSM (me) were laid off back in February, so it is unlikely to be fixed client-side any time soon.

You can try poking Ben (from Rapid; no clue what he is working on now) to see if someone can fix it server side.

Bryan and I were going to start moving the conflation logic from the server to the clients this year, but that (obviously) won't be happening.

comment:3 by BalooUriza, 4 days ago

What is the best way to contact Ben?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain taylor.smock.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from taylor.smock to the specified user.
Next status will be 'needinfo'. The owner will be changed from taylor.smock to BalooUriza.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from taylor.smock to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.