Clicking undo on two error messages reverts change and previous change

[LordGarySugar]

As shown in the video, I moved a way with more than 20 nodes more than 500m which triggered two error messages. I clicked undo on both, which undid the move and then also undid the prevous change, in this example a reconstruction of a multipolygon.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2025-03-29 21:08:34 +0100 (Sat, 29 Mar 2025)
Revision:19369
Build-Date:2025-03-30 01:30:37
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19369 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Home 22H2 (19045)
Memory Usage: 408 MB / 8176 MB (70 MB allocated, but free)
Java version: 21.0.5+11-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 2560x1440x32bpp@165Hz (scaling 1.00×1.00)
Maximum Screen Size: 2560×1440
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=C:\Program Files\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djava.security.manager=allow]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (36413)
+ buildings_tools (36413)
+ gridify (1743059510)
+ imagery_offset_db (36413)
+ jaxb (36415)
+ jogl (1.2.3)
+ log4j (36413)
+ markseen (172)
+ reltoolbox (36413)
+ reverter (36413)
+ terracer (36413)
+ turnlanes (36413)
+ utilsplugin2 (36413)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1
+ https://gitlab.com/cartocite/josm-style-traffic-signs-orientation/-/raw/main/traffic_sign_orientation_style.zip
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/iD&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss

Last errors/warnings:
- 00066.830 W: java.io.IOException: Attribution is not loaded yet
- 00066.831 W: java.io.IOException: Attribution is not loaded yet
- 00066.831 W: java.io.IOException: Attribution is not loaded yet
- 00066.831 W: java.io.IOException: Attribution is not loaded yet
- 00066.831 W: java.io.IOException: Attribution is not loaded yet
- 00066.831 W: java.io.IOException: Attribution is not loaded yet
- 00066.832 W: java.io.IOException: Attribution is not loaded yet
- 00066.832 W: java.io.IOException: Attribution is not loaded yet
- 00066.832 W: java.io.IOException: Attribution is not loaded yet
- 00066.832 W: java.io.IOException: Attribution is not loaded yet

[stoecker]

There should only be a combined message.

[GerdP]

check if command was already undone before performing the second check

[stoecker]

Do you apply it yourself?

[GerdP]

OK, will do tomorrow.

[GerdP]

In 19411/josm:

fix #24255: Clicking undo on two error messages reverts change and previous change

• don't show popup for move of multiple nodes when the popup fpr long-distance move already was answered with Cancel so that the move was undone.