Modify

Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#24176 closed defect (fixed)

When drawing rail platform edges all nodes except the end nodes get a switch warning

Reported by: SekeRob Owned by: team
Priority: minor Milestone: 25.02
Component: Core validator Version: tested
Keywords: template_report Cc: SekeRob, gaben

Description

Been many a platform and edge since discussion on community forum and finding the plat_edge way/tags are very sparsely used in Italy. Started a mapping crusade in my region of adding rail station platforms mostly as area and adding the edge lines with ref.

What steps will reproduce the problem?

  1. Draw a platform area typically along the bend in a railway.
  2. Along the platform rail side draw a line tagged as railway=platform_edge
  3. Validate and get "Railway connection node without railway=switch or railway=railway_crossing" on all nodes but the ends.

What is the expected result?

No reason to flag in validation cycle.

What happens instead?

The warning in point 3 above.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2025-02-03 20:59:54 +0100 (Mon, 03 Feb 2025)
Revision:19307
Build-Date:2025-02-04 02:30:32
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19307 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 22H2 (19045)
Memory Usage: 2188 MB / 4084 MB (851 MB allocated, but free)
Java version: 21.0.5+11-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080x32bpp@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=%UserProfile%\AppData\Local\Programs\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djava.security.manager=allow]
Dataset consistency test: No problems found

Plugins:
+ Elevation (0.10.1)
+ ElevationProfile (36360)
+ FixAddresses (36387)
+ HouseNumberTaggingTool (36368)
+ KartaView (545)
+ MakeParallel (v1.1.0)
+ Mapillary (1792)
+ MicrosoftStreetside (36370)
+ OpeningHoursEditor (36360)
+ QuickLabel (23)
+ RoadSigns (36343)
+ apache-commons (36366)
+ buildings_tools (36370)
+ comfort0 (36379)
+ contourmerge (v0.2.2)
+ easypresets (1623509627)
+ flatlaf (36370)
+ graphview (36370)
+ gridify (1738594923)
+ highwaynamemodification (68)
+ javafx (36370)
+ josm_magic_wand (3.0.0)
+ libphonenumber (8.13.54)
+ measurement (36360)
+ movemembership (1.3.0)
+ notesolver (0.5.0)
+ phonenumber (1.1.1)
+ pt_assistant (646)
+ reltoolbox (36344)
+ reverter (36354)
+ routing (36343)
+ scripting (v0.3.4)
+ tageditor (36350)
+ terracer (36344)
+ todo (145)
+ turnlanes (36360)
+ turnlanes-tagging (1727811971)
+ turnrestrictions (36344)
+ undelete (36349)
+ utilsplugin2 (36370)

Tagging presets:
+ <josm.pref>/EasyPresets.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Golf_Course&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/AdvertisingPreset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Maxspeed-zones&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Manholes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/TurnLanes&zip=1
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Potlach2_access&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ColorWays&zip=1
- https://josm.openstreetmap.de/josmfile?page=Rules/IncompleteObjectWarnings&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings_en&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
+ https://gitlab.com/cartocite/josm-style-traffic-signs-orientation/-/raw/main/traffic_sign_orientation_style.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR_OC.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://raw.githubusercontent.com/OpenNauticalChart/josm/master/european-waterways-classification-style/CEMT-style.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Waterways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NewParkingFeatures&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PriorityRoad&zip=1

Last errors/warnings:
- 00672.542 W: java.io.IOException: Attribution is not loaded yet
- 00672.543 W: java.io.IOException: Attribution is not loaded yet
- 00672.544 W: java.io.IOException: Attribution is not loaded yet
- 00672.544 W: java.io.IOException: Attribution is not loaded yet
- 00672.545 W: java.io.IOException: Attribution is not loaded yet
- 00672.546 W: java.io.IOException: Attribution is not loaded yet
- 00672.546 W: java.io.IOException: Attribution is not loaded yet
- 00672.547 W: java.io.IOException: Attribution is not loaded yet
- 00672.548 W: java.io.IOException: Attribution is not loaded yet
- 00672.549 W: java.io.IOException: Attribution is not loaded yet

Attachments (1)

error.osm (3.0 KB ) - added by stoecker 7 months ago.

Download all attachments as: .zip

Change History (12)

comment:1 by SekeRob, 7 months ago

Absent ability to modify ticket opener (still not able to get email account verification working)

plat_edge > platform_edge

comment:2 by stoecker, 7 months ago

Please attach an example file.

comment:3 by gaben, 7 months ago

Component: CoreCore validator

@stoecker, I cannot change the ticket status to needinfo, Trac saying:

  • TicketWorkflowOpOwnerReporter changed "owner" to "SekeRob", but ConfigurableTicketWorkflow changed it to "team".
  • Please review your configuration, probably starting with

[ticket]
workflow = ...
in your trac.ini.

comment:4 by stoecker, 7 months ago

Owner: changed from team to SekeRob
Status: newneedinfo

Some actions need two steps...

comment:5 by SekeRob, 7 months ago

@stoecker

This is todays object with 4 nodes. https://www.openstreetmap.org/way/1363055877 . Added 5th node, no warning on validation. Then when mapping new platform + edge having 3 nodes, the centre node is flagged. YCMTU

by stoecker, 7 months ago

Attachment: error.osm added

comment:6 by stoecker, 7 months ago

Now when I load that OSM file and add a fifth point, then I get 3 warnings which does not match your previous comment.

Should the warnings be there or not at all? I don't know what that warnings target is, but it seem MapCSS needs an exception for that usecase.

comment:7 by SekeRob, 7 months ago

Weird. No, that warning is false. it's a railway platform part not a rail that splits or joins with a second binary. There the switch tags would have to be added albeit never did one and on checking The bigger Pescara station which goes from 2 lines into 12 along platforms has not got a single tagged, just connection nodes.

This wiki visualized them: https://wiki.openstreetmap.org/wiki/Tag%3Arailway%3Dswitch

An Overpass run shows them largely missing if you centre Rome & Pescara on the screen (central Italy) and run the script: https://overpass-turbo.eu/?key=railway&value=switch&template=key-value

... totally surprised of with their greater absence, something else a crusade is needed for. 😣

comment:8 by skyper, 7 months ago

Cc: gaben added
Owner: changed from SekeRob to team
Status: needinfonew

Seem nobody thought about excluding railway=platform_edge in #21801 (r19163).

comment:9 by stoecker, 7 months ago

Resolution: fixed
Status: newclosed

In 19342/josm:

see #21801, fix #24176 - don't issue useless warning for railway=platform_edge

comment:10 by stoecker, 7 months ago

Milestone: 25.02

Thanks for the hint.

in reply to:  8 comment:11 by gaben, 7 months ago

Replying to skyper:

Seem nobody thought about excluding railway=platform_edge in #21801 (r19163).

This is exactly what happened! :) Even though I tested the committed version across Europe, it seems I missed Italy.

Tbh, I started reading the original report here and after about three sentences I lost track of what the problem was... Anyway, thanks for the report, everything is a learning opportunity.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.