[patch] Show graceful message after successful plugin download

[gaben]

What steps will reproduce the problem?

1. Download a plugin, gridify in my example
2. Check the status window

What is the expected result?

If the download is successful, don't show warning, but information(?). Like this:

What happens instead?

After successful download, JOSM saying warning for no reason.

Please provide any additional information below. Attach a screenshot if possible.

Revision:19334
Is-Local-Build:true
Build-Date:2025-02-21 10:06:03

After borrowing some code from PluginPreference class, it works as expected.

src/org/openstreetmap/josm/gui/preferences/PreferenceTabbedPane.java

@@ -139 +139 @@
                     MainApplication.getMenu().restart.actionPerformed(null);
                 }
             } else if (task != null && !task.isCanceled()) {
+                Collection<PluginInformation> failed = task.getFailedPlugins();
                 JOptionPane.showMessageDialog(
                         MainApplication.getMainFrame(),
                         sb.toString(),
-                        tr("Warning"),
-                        JOptionPane.WARNING_MESSAGE
+                        !failed.isEmpty() ? tr("Warning") : tr("Information"),
+                        !failed.isEmpty() ? JOptionPane.WARNING_MESSAGE : JOptionPane.INFORMATION_MESSAGE
                         );
             }

[gaben]

The code around this panel could be simplified/refactored because it feels like glue sometimes. E.g. the task failure check is done twice, once for the UI, and once for the strings in two separate classes. Anyway, the patch I proposed is a quick fix.

[stoecker]

LGTM

[stoecker]

In 19335/josm:

fix #24163 - patch by gaben - don't flag success as warning

[stoecker]

In 19338/josm:

see #24163 - fix tests