Unexpected Exception when increasing value of "downloadAlongWay.area"

[martien-vdg]

What steps will reproduce the problem?

1. In Preferences -> Advanced Preferences go to setting "downloadAlongWay.area"
2. Increase value to a number greater than 25.0
3. Click OK
4. File -> Download along...

What is the expected result?

Or just accept the increased value. Or get a message with appropriate information about what is going on

What happens instead?

An Unexpected exception appears

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2025-01-02 12:51:21 +0100 (Thu, 02 Jan 2025)
Revision:19277
Build-Date:2025-01-03 02:30:34
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19277 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 22H2 (19045)
Memory Usage: 1080 MB / 4070 MB (555 MB allocated, but free)
Java version: 17.0.11+9, Eclipse Adoptium, OpenJDK 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatDarculaLaf
Screen: \Display0 1920x1080x32bpp@60Hz (scaling 1.25×1.25) \Display1 1920x1200x32bpp@59Hz (scaling 1.25×1.25) \Display2 1920x1080x32bpp@59Hz (scaling 1.25×1.25)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Duser.home=%UserProfile%]
Dataset consistency test: No problems found

Plugins:
+ CADTools (23)
+ Create_grid_of_ways (36344)
+ FastDraw (36344)
+ Mapillary (1789)
+ SimplifyArea (36344)
+ apache-commons (36349)
+ apache-http (36349)
+ buildings_tools (36344)
+ changeset-viewer (0.0.8)
+ continuosDownload (107)
+ flatlaf (36349)
+ gridify (1718663815)
+ jackson (36349)
+ jna (36349)
+ log4j (36348)
+ mapathoner (1.5.5)
+ markseen (14)
+ measurement (36350)
+ reltoolbox (36344)
+ reverter (36354)
+ scripting (v0.3.1)
+ terracer (36344)
+ todo (141)
+ turnrestrictions (36344)
+ undelete (36349)
+ utilsplugin2 (36362)

Tagging presets:
+ C:\Users\Public\Documents\portableappsPlatform\scripts\josm.building.xml

Map paint styles:
+ https://gitlab.com/peculiar-theater/mapcss/-/raw/main/tm-taskgrid/tm-taskgrid.mapcss
+ https://github.com/MissingMaps/josm_styles/archive/master.zip
+ https://github.com/osmlab/applepaintstyles/archive/main.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/ColorWays&style
+ https://josm.openstreetmap.de/josmfile?page=Styles/NewModifiedBuildings&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ModifiedHighways&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1
- https://github.com/osmlab/appledata/archive/josm_paint_inline_validation.zip
- https://gitlab.com/peculiar-theater/mapcss/-/archive/main/mapcss-main.zip?path=tm-taskgrid
- C:\Users\<user.name>\Desktop\HOT OSM\mapcss\modified-highways\modified-highways.mapcss
- C:\Users\<user.name>\Desktop\HOT OSM\mapcss\new-modified-buildings\test\test-new-modified.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- C:\Users\<user.name>\Desktop\HOT OSM\mapcss\user.mapcss
- https://github.com/MissingMaps/josm_styles/archive/master.zip
- https://raw.githubusercontent.com/MarkCupitt/HOT-Osm-Validation/44b408bcfb9818e7f6a69eea7022d26299a7ba7a/HOT-Validate.mapcss
- https://github.com/hotosm/HDM-JOSM-style/archive/master.zip
- https://github.com/osmlab/applepaintstyles/archive/main.zip

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/QAToolInspiredValidations&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/ValidatingBuildingsInHOTTMProjects&zip=1

Last errors/warnings:
- 00000.703 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.705 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00004.722 W: Failed to delete outdated plugin '<josm.pref>\plugins\flatlaf.jar'.
- 00004.722 W: Failed to install already downloaded plugin 'flatlaf'. Skipping installation. JOSM is still going to load the old plugin version.
- 00104.961 E: Handled by bug report queue: java.lang.IllegalArgumentException: (minimum <= value <= maximum) is false
- 00146.055 E: Handled by bug report queue: java.lang.IllegalArgumentException: (minimum <= value <= maximum) is false
- 00355.965 E: Handled by bug report queue: java.lang.IllegalArgumentException: (minimum <= value <= maximum) is false
- 11037.316 E: Handled by bug report queue: java.lang.IllegalArgumentException: (minimum <= value <= maximum) is false
- 13541.078 E: Handled by bug report queue: java.lang.IllegalArgumentException: (minimum <= value <= maximum) is false



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (22) of main
java.lang.IllegalArgumentException: (minimum <= value <= maximum) is false
	at java.desktop/javax.swing.SpinnerNumberModel.<init>(SpinnerNumberModel.java:139)
	at java.desktop/javax.swing.SpinnerNumberModel.<init>(SpinnerNumberModel.java:178)
	at org.openstreetmap.josm.gui.layer.gpx.DownloadAlongPanel.<init>(DownloadAlongPanel.java:82)
	at org.openstreetmap.josm.actions.DownloadAlongWayAction.createTask(DownloadAlongWayAction.java:52)
	at org.openstreetmap.josm.actions.DownloadAlongAction.actionPerformed(DownloadAlongAction.java:308)
	at java.desktop/javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1810)
	at java.desktop/javax.swing.JComponent.processKeyBinding(JComponent.java:2947)
	at java.desktop/javax.swing.KeyboardManager.fireBinding(KeyboardManager.java:311)
	at java.desktop/javax.swing.KeyboardManager.fireKeyboardAction(KeyboardManager.java:266)
	at java.desktop/javax.swing.JComponent.processKeyBindingsForAllComponents(JComponent.java:3040)
	at java.desktop/javax.swing.JComponent.processKeyBindings(JComponent.java:3032)
	at java.desktop/javax.swing.JComponent.processKeyEvent(JComponent.java:2909)
	at java.desktop/java.awt.Component.processEvent(Component.java:6403)
	at java.desktop/java.awt.Container.processEvent(Container.java:2266)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5001)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4833)
	at java.desktop/java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1952)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:883)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1150)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:1020)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:848)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4882)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2780)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4833)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:775)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:720)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:714)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:97)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:747)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:744)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

[taylor.smock]

Looks like that (0.01 - 25.0).

new SpinnerNumberModel(Config.getPref().getDouble(prefArea, 20.0), 0.01, 25.0, 0.01)

What we can do to "fix" this is one of the following:

1. Math.clamp the prefArea to 0.01 - 25.0
2. Change the max to whatever the prefArea config is set to for this session
3. Actually use the maximum attribute from the area element in ​https://api.openstreetmap.org/api/0.6/capabilities (0.25).

Problem with 1: it doesn't fulfill the desires of the user if they intended to have a larger download area
Problem with 2: it may cause issues elsewhere when downloading (e.g. if it is set such that the area is greater than 0.25 degrees).
Problem with 3: Docs indicate that the current area is in square kilometers. Not square degrees. Docs in significant usage location is that the "maximum we ever offer is a bbox area of 0.002" since most built up areas will have incomplete downloads due to stopping at 50k nodes.

Therefore, IMO, the best option would be to clamp the prefArea to between 0.01 and 25.0.