Modify

Opened 4 hours ago

Last modified 2 hours ago

#24033 new enhancement

There should be a validator warning for the deprecated key building:roof

Reported by: goodidea Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: building:roof Cc:

Description

The key building:roof=* is deprecated (according to the wiki in favor of roof:material=*, see https://wiki.openstreetmap.org/wiki/Key:building:roof). There should be a validator warning for this deprecated key.

A note: a saw this key not only with material values, but also with roof shape values, e.g. building:roof=flat (or gabled/hipped/...). According to taginfo, espacially the tag building:roof=flat is still used 10627 times! See https://taginfo.openstreetmap.org/keys/building:roof#values. So maybe the warning text of the validator should not only specify roof:material=* as a replacement (like in the wiki), but also roof:shape=* ...

One more note: At the moment there is already a validator warning for another similar deprecated key building:roof:shape=*, see https://josm.openstreetmap.de/changeset/17942/josm.

Attachments (0)

Change History (1)

comment:1 by taylor.smock, 2 hours ago

That looks more like a case for an automated edit. Have you looked into doing that (there are some good practices for that on the wiki)? It does take community buy-in, but will be much faster.

One caveat is that the values may no longer be correct, since buildings tend to be reroofed from time to time.

As an alternative, you can make a maproulette tag fix challenge that changes the tag to match current tagging standards, and have the community fix it.

I'm kind of disinclined to add it to the deprecated list, since it doesn't look like the tag is being actively added.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to goodidea.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.