[PATCH] Add railway=train_station_entrance to standard preset and mapstyle

[Claudius]

​railway=train_station_entrance is a documented tag which already sees more than 8300 uses mainly in Europe but also across the world. It allows tagging train station entrances different than subway entrances which is what currently still largely is (ab)used as tagging.

This tag adds a new icon created by me based on the subway entrance icon but coloured black/white to fit into the railway icon theme. This icon is then added to the default mappaint ruleset.

[Claudius]

New black/white station entrance icon based off the existing blue/white underground.svg - I grant free use of that icon

[Claudius]

Patch file adding the icon and modifying the standard mappaint styling

[skyper]

If we add it to the default style, shouldn't we add a preset along side. Shouldn't be much of a task as most of the work is already done in finding/creating an icon.

[Claudius]

Enhanced patch to also add a preset for the train station entrance (this also adds the optional reference field to the subway entrances preset for consistency)

[Claudius]

Replying to skyper:

If we add it to the default style, shouldn't we add a preset along side. Shouldn't be much of a task as most of the work is already done in finding/creating an icon.

Good point. I've attached the updated patch which also adds "Train Station Entrance" to the default preset next to "Subway entrance". I also used the opportunity to add the optional reference field to the subway entrance preset since that is quite common for numbered exits in our data.

[skyper]

Thanks.
How about adding level=* as optional: <combo key="level" text="Storey" values="5,4,3,2,1,0,-1,-2,-3,-4,-5" values_sort="false" /> ?
We could save two lines referencing the chunk name_ref.

Edit: Correct values for level

[Claudius]

Using name_ref chunk for the name+ref combination in defaultpreset now

[Claudius]

Thanks for the name_ref chunk hint. I've updated the patch accordingly to use that.

Replying to skyper:

How about adding level=* as optional: <combo key="level" text="Storey" values="5,4,3,2,1,0,-1,-2,-3,-4,-5" values_sort="false" /> ?

Subway and train station entrances for the very vast majority of cases (except Chongqing of course) are at street level (either embedded in the highway surface or building walls). So using levels for tagging entrances is virtually non-existant as the automatic assumed default level=0 works most of the time. No need to add levels to the preset therefor.

[skyper]

Fine, if needed, we can always add optional tags later.