Mapillary Plugin crash

[Macsico]

What steps will reproduce the problem?

(In this case, this were the steps done right before the crash dialogue appeared. Happened only once, sorry)

1. Activating the Mapillary layer
2. Clicking on single image
3. Crash dialog appears

What is the expected result?

• selected Mapillary image should be visible in JOSM image window

What happens instead?

• crash dialogue appeared asking if plugin should be disabled or used
• additional crash dialogue with Stack Trace opened and advised to create ticket

Please provide any additional information below. Attach a screenshot if possible.

Revision:19207
Build-Date:2024-09-03 10:33:48

Identification: JOSM/1.5 (19207 de) Mac OS X 10.14.6
OS Build number: Mac OS X 10.14.6 (18G9323)
Memory Usage: 2048 MB / 2048 MB (727 MB allocated, but free)
Java version: 21.0.4+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 1007453121 1920x1200x32bpp@59Hz (scaling 1.00×1.00) Display 69677248 1280x800x32bpp@[Unknown refresh rate] (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: de_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=19207, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=/Applications/JOSM.app/Contents/MacOS/JOSM]
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (36298)
+ FastDraw (36226)
+ FixAddresses (36298)
+ HouseNumberTaggingTool (36298)
+ Mapillary (1770.1)
+ apache-commons (36282)
+ apache-http (36273)
+ buildings_tools (36226)
+ graphview (36298)
+ jna (36273)
+ namemanager (36298)
+ photo_geotagging (36298)
+ photoadjust (36200)
+ reverter (36320)
+ tageditor (36298)
+ utilsplugin2 (36298)
+ wikipedia (418)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Bench&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksAndFootways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1

Last errors/warnings:
- 00426.584 W: Already here java.net.ConnectException: Connection refused
- 00426.589 W: java.net.ConnectException: Connection refused
- 00426.591 W: Already here java.net.ConnectException: Connection refused
- 00426.596 W: java.net.ConnectException: Connection refused
- 00426.600 W: Already here java.net.ConnectException: Connection refused
- 00426.603 W: java.net.ConnectException: Connection refused
- 00426.607 W: Already here java.net.ConnectException: Connection refused
- 00426.609 W: java.net.ConnectException: Connection refused
- 00426.612 W: Already here java.net.ConnectException: Connection refused
- 00426.696 E: Handled by bug report queue: org.openstreetmap.josm.tools.JosmRuntimeException: java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Mapillary sequence xfK8S3ZtdEXhqo1RODnPLy did not download any images. Ursache: java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Mapillary sequence xfK8S3ZtdEXhqo1RODnPLy did not download any images. Ursache: java.lang.IllegalArgumentException: Mapillary sequence xfK8S3ZtdEXhqo1RODnPLy did not download any images



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (32) of main
org.openstreetmap.josm.tools.JosmRuntimeException: java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Mapillary sequence xfK8S3ZtdEXhqo1RODnPLy did not download any images
	at org.openstreetmap.josm.plugins.mapillary.gui.workers.MapillarySequenceDownloader.done(MapillarySequenceDownloader.java:173)
	at java.desktop@21.0.4/javax.swing.SwingWorker$4.run(Unknown Source)
	at java.desktop@21.0.4/javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.run(Unknown Source)
	at java.desktop@21.0.4/sun.swing.AccumulativeRunnable.run(Unknown Source)
	at java.desktop@21.0.4/javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.actionPerformed(Unknown Source)
	at java.desktop@21.0.4/javax.swing.Timer.fireActionPerformed(Unknown Source)
	at java.desktop@21.0.4/javax.swing.Timer$DoPostEvent.run(Unknown Source)
	at java.desktop@21.0.4/java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.desktop@21.0.4/java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.desktop@21.0.4/java.awt.EventQueue$4.run(Unknown Source)
	at java.desktop@21.0.4/java.awt.EventQueue$4.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop@21.0.4/java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.desktop@21.0.4/java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.desktop@21.0.4/java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.desktop@21.0.4/java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.desktop@21.0.4/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop@21.0.4/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop@21.0.4/java.awt.EventDispatchThread.run(Unknown Source)
Caused by: java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Mapillary sequence xfK8S3ZtdEXhqo1RODnPLy did not download any images
	at java.base/java.util.concurrent.FutureTask.report(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.get(Unknown Source)
	at java.desktop@21.0.4/javax.swing.SwingWorker.get(Unknown Source)
	at org.openstreetmap.josm.plugins.mapillary.gui.workers.MapillarySequenceDownloader.done(MapillarySequenceDownloader.java:168)
	... 19 more
Caused by: java.lang.IllegalArgumentException: Mapillary sequence xfK8S3ZtdEXhqo1RODnPLy did not download any images
	at org.openstreetmap.josm.plugins.mapillary.gui.workers.MapillarySequenceDownloader.getImageRange(MapillarySequenceDownloader.java:128)
	at org.openstreetmap.josm.plugins.mapillary.gui.workers.MapillarySequenceDownloader.lambda$doInBackground$0(MapillarySequenceDownloader.java:106)
	at org.openstreetmap.josm.plugins.mapillary.gui.workers.MapillarySequenceDownloader.doInBackground(MapillarySequenceDownloader.java:113)
	at org.openstreetmap.josm.plugins.mapillary.gui.workers.MapillarySequenceDownloader.doInBackground(MapillarySequenceDownloader.java:26)
	at java.desktop@21.0.4/javax.swing.SwingWorker$1.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.desktop@21.0.4/javax.swing.SwingWorker.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)

[Macsico]

This is my very first JOSM ticket with my very first JOSM plugin crash. So please be kind as the tickets first version was created in a hurry right before an appointment. Now it should be more polished and useful.

[taylor.smock]

This is fun. That sequence actually has images.

My "best guess" is that one of two things happened:

1. Mapillary servers were down at the time
2. Your internet connection was having issues at the time

The reason why I say that is there are (by default) 10 download attempts for a sequence before we give up.

The hard part (for me) is I don't know what the exact reasons for the download failure are. If you had connection errors, it is also possible that we got an incomplete response.

[taylor.smock]

​https://github.com/JOSM/Mapillary/pull/237 may help, depending upon what the actual failure is.

I'll try to get a release out today so that you can test -- the big thing is that it will still throw an exception if the number of images expected do not match the number of images downloaded. But there will still be an exception. Just a more informative one.

[Macsico]

Thanks for your quick analysis and the update.

Yes, the sequence has images - for all current Mapillary sequences of this cemetery I am the only creator so far.

To hopefully bring some light into the crash here are additional infos about my current home network setup which might explain your observations:

• for privacy and security reasons, aggressive adblocking and internet connection restrictions is running (Adguard Home with 4 different DNS providers, Adblock list subscriptions on OpenWRT router, LuLu on MacOS). The option to block all Facebook services via Adguard Home is also selected.

• to upload my images to Mapillary and check my own coverage I use various workarounds (upload: an intermediate Shared Hosting server outside of my network via SSH/SFTP, download: Opera browser with VPN tunnel) to circumvent my own network restrictions as outlined above. Mapillary coverage availability is very important for one of my spare time workgroups, so I contribute and use it very often.

AdGuard Home is still new to me and has shown mixed results so far, as most of the blocking attempts are happening as expected, and sometimes not. Especially Facebook/Mapillary connections have shown this irritating behaviour.

My internet connection: DSL landline with 50/10 MBit, running in inner city Berlin, Germany. Should not be that unstable, right?

So, does my network setup ring any bell on your side?

Your github commit is already installed and images do show up in JOSM. No additonal plugin crash happened so far during a few sessions this week.