openindoor: Port 8432: Conflicts with another plugin and makes JOSM unable to startup due to conflict in port usage.

[osmidal]

Ahoj,

the plugin "openindoor" and another plugin (I do not know which) do conflict:

When I install both, and (re)start JOSM, it fails to start before even showing the UI, because two plugins want to use port 8432:

[...]
2024-07-23 18:42:19.946 INFO: loading plugin 'openindoor-1.0.2-josm' (version UNKNOWN)

====================Server Details====================
Server Machine: [censored].localdomain
Port number: 8432

Error occured:Address already in use

I suggest to not block starting up but to show a dialogue telling about the port conflict and pointing the user to where to change the port number (within the GUI) to solve the conflict.

Regards!

[stoecker]

Thanks for your report, however your ticket is incomplete and therefore not helpful in its current form.

Please add all needed information according to this list:

• The required parts of the Status Report from your JOSM.
  • Please, use Report Bug from Help menu and copy & paste.
• Describe what behaviour you expected.
• Describe what did happen instead.
• Describe if and how the issue is reproducible.
• Add any relevant information like error messages or screenshots.

To ensure that all technical relevant information is contained, create new tickets by clicking in JOSMs Main Menu on Help → Report Bug.

Remember: This is a generic notice so we don't need to write the same stuff again and again. It may only apply in parts to the specific case!

[osmidal]

Replying to stoecker:

Please, use Report Bug from Help menu

As I wrote, the application does not start up so this is _not possible_!

[stoecker]

You get similar information when calling josm --debug. And if not you can tell us your josm version, java version, OS, distribution, installed plugins etc without the aid of the Status Report.

[taylor.smock]

Assuming you are familiar with the command line, you can also do the following:
java -jar josm.jar --status-report (or if josm is the command, josm --status-report).

[osmidal]

josm --debug terminal output

[osmidal]

josm --status-report terminal output

[osmidal]

josm --debug --status-report terminal output

[osmidal]

Replying to stoecker:

You get similar information when calling josm --debug.

Done, see this attachment.

Replying to stoecker:

And if not you can tell us your josm version

josm --version: JOSM/1.5 (19167 SVN en) Linux Artix Linux

java version

java --version | head -n1: openjdk 23 2024-09-17

OS, distribution

​Artix GNU/Linux

installed plugins etc without the aid of the Status Report.

ls -1F ~/.local/share/JOSM/plugins/:

AddrInterpolation.jar
alignways.jar
apache-commons.jar
apache-http.jar
areaselector.jar
austriaaddresshelper.jar
auto_tools.jar
BuildingGeneralization.jar
buildings_tools.jar
CADTools.jar
centernode.jar
changeset-viewer.jar
changessum.jar
ColorPlugin.jar
colorscheme.jar
comfort0.jar
CommandLine.jar
conflation.jar
contourmerge.jar
Create_grid_of_ways.jar
CustomizePublicTransportStop.jar
damn.jar
dataimport.jar
DirectDownload.jar
DirectUpload.jar
DxfImport.jar
easypresets.jar
editgpx.jar
ejml.jar
Elevation.jar
ElevationProfile.jar
FastDraw.jar
fastdriveway.jar
fieldpapers.jar
FixAddresses.jar
gcsenabler-v0.0.1.jar
geochat.jar
geohash.jar
geotools.jar
gpsblam.jar
graphview.jar
gridify.jar
highwaynamemodification.jar
HouseNumberTaggingTool.jar
ImageIO.jar
imagery_offset_db.jar
imagery-xml-bounds.jar
ImageWayPoint.jar
ImportImagePlugin/
ImportImagePlugin.jar
importvec.jar
ImproveWay.jar
indoorequal.jar
indoorhelper/
indoorhelper.jar
indoor_sweepline.jar
InfoMode.jar
intersection.jar
jackson.jar
jaxb.jar
jna.jar
jogl/
jogl.jar
josm-batch-downloader.jar
josm_magic_wand.jar
jts.jar
junctionchecking.jar
kartverketimport.jar
kendzi3d.jar
kendzi3d-resources.jar
libphonenumber.jar
livegps.jar
log4j.jar
logfile_indoorhelper.log
logfile_indoorhelper.log.1
logfile_indoorhelper.log.1.lck
logfile_indoorhelper.log.lck
MakeParallel.jar
mapathoner.jar
Mapillary/
Mapillary.jar
mapwithai.jar
markseen.jar
mbtiles.jar
measurement.jar
merge-overlap.jar
microdata_scraping.jar
movemembership.jar
namemanager.jar
notesolver.jar
o5m.jar
ohm-date-filter.jar
opendata/
opendata.jar
openindoor-1.0.2-josm.jar
OpeningHoursEditor.jar
openqa.jar
openvisible.jar
osmai.jar
osm-obj-info.jar
osmwiki-dataitem.jar
pbf.jar
pdfimport.jar
PerpendicularWayFromNode.jar
phonenumber.jar
photoadjust.jar
photo_geotagging.jar
PicLayer.jar
plbuildings.jar
pmtiles.jar
pointInfo.jar
PolygonCutOut.jar
poly.jar
print.jar
pt_assistant.jar
public_transport.jar
QuickLabel.jar
rasterfilters/
rasterfilters.jar
RelationDissolve.jar
Relation.Validation.Plugin.jar
reltoolbox.jar
reverter.jar
Review.Changes.jar
rex.jar
RoadSigns.jar
routes/
routes.jar
routing.jar
SeaChart.jar
SeaMapEditor.jar
ShapeTools.jar
shrinkwrap.jar
sidewalks.jar
SimplifyArea.jar
site-josm.openstreetmap.de-_pluginicons.txt
splinex.jar
surveyor.jar
tageditor.jar
tagging-preset-tester.jar
terracer.jar
todo.jar
tofix.jar
TombPlugin.jar
touchscreenhelper.jar
Tracer2/
Tracer2.jar
Tracer.jar
Tracks2Map.jar
turnlanes.jar
turnlanes-tagging.jar
turnrestrictions.jar
uberterracer.jar
undelete.jar
utilsplugin2.jar
waydownloader.jar
waypoint_search.jar
webp-v0.0.4.jar
wikipedia.jar

Replying to taylor.smock:

Assuming you are familiar with the command line, you can also do the following:
java -jar josm.jar --status-report (or if josm is the command, josm --status-report).

See this attachment for the output of josm --status-report and this attachment for the output of josm --debug --status-report. Note that it did not terminate, I had to abort with <Ctrl>+<C>.

Does this help?
Regards!

[taylor.smock]

openindoor-1.0.2-josm.jar

It looks like 1.0.2 isn't the "latest" source from openindoor.

This matters since 1.0.2 supposedly fixed the system.exit problem (see ​OIDPlugin.java#L71). This was fixed in ​v1.0.2.

I'll check and see what other plugin is listening to a socket. I'll see about giving them a GitHub action that will do autobuild and releases. Assuming they respond. If they don't, we can block the plugin.

It looks like indoorequal is loaded, and then openindoor is loaded; since openindoor is loaded second, it exits.

With that said, I'm guessing the other problem is with the ​indoorequal plugin. It looks like the indoorequal plugin is a fork or continuance of the openindoor plugin.

[stoecker]

Note: if you are installing so many plugins you will act as a beta tester for all plugin authors. I'd recommend to only install plugins you need. There are usually reasons why the functionality isn't in josm directly.

[osmidal]

Replying to taylor.smock:

openindoor-1.0.2-josm.jar

It looks like 1.0.2 isn't the "latest" source from openindoor.

But it is the latest I am offered from within JOSM's plugin installation dialogue.

This matters since 1.0.2 supposedly fixed the system.exit problem

And 1.0.2 is offered from within JOSM. ??

It looks like indoorequal is loaded, and then openindoor is loaded; since openindoor is loaded second, it exits.

I can confirm: Disabling indoorequal, and enabling openindoor, makes JOSM starting.

So, indoorequal and openindoor are causing the conflict. (I suppose this issue should now be tagged to the addon indoorequal as well?)

It looks like the indoorequal plugin is a fork or continuance of the openindoor plugin.

So maybe openindoor should be removed from JOSM's plugin list?

Replying to stoecker:

Note: if you are installing so many plugins you will act as a beta tester for all plugin authors.

So you get feedback about issues, I see no problem with this.

Regards!

[taylor.smock]

Replying to osmidal:

Replying to taylor.smock:

It looks like 1.0.2 isn't the "latest" source from openindoor.

But it is the latest I am offered from within JOSM's plugin installation dialogue.

You might want to double-check the JAR that is provided by openindoor. If I do the following:

$ curl -LO https://github.com/open-indoor/openindoor-josm-plugin/releases/download/v1.0.2/openindoor-1.0.2-josm.jar
$ unzip -l openindoor-1.0.2-josm.jar| grep OIDPlugin
     2859  12-20-2021 19:54   org/openstreetmap/josm/plugins/openindoor/OIDPlugin.class

OIDPlugin.java was ​renamed to OpenIndoorPlugin.java in 1.0.2.

This matters since 1.0.2 supposedly fixed the system.exit problem

And 1.0.2 is offered from within JOSM. ??

As noted above, it looks like openindoor uploaded an old version as 1.0.2.

I can confirm: Disabling indoorequal, and enabling openindoor, makes JOSM starting.

So, indoorequal and openindoor are causing the conflict. (I suppose this issue should now be tagged to the addon indoorequal as well?)

No; indoorequal is behaving properly and not exiting JOSM when the socket they want to use is taken.

So maybe openindoor should be removed from JOSM's plugin list?

Maybe. But we should give openindoor a chance to fix the problem. With that said, I am not hopeful. On the plus side, since openindoor never fixed the version problem that stoecker complained about, we can just disable the problematic version on all installs (on JOSM upgrade). And if they ever release a new (fixed) version, we won't have to back out the change.

TBH, the project is probably dead. If they haven't responded by the end of the month, I think we can be justified in removing it from the plugin list and blacklisting the plugin.

[taylor.smock]

openindoor has been removed from the download list, see wiki:PluginsSource?action=diff&version=810