[patch] Convert existing MapCSS rules to use the new siunit_length() function

[gaben]

The function is available since r19089.

Requested by Famlam in ticket:23621#comment:24.

[Famlam]

Well, requested... suggested :)

The only two I saw so far are:
1) the one linked in the initial post of this ticket
2) the way[highway=pedestrian][width][width<3] check in combinations.mapcss

[gaben]

The patch so far:

resources/data/validator/combinations.mapcss

@@ -756 +756 @@
 }
 
 /* #17391 */
-way[highway=pedestrian][width][width<3] {
+way[highway=pedestrian][width][siunit_length(tag(width))<3] {
   throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
   suggestAlternative: "highway=footway";
   group: tr("suspicious tag combination");

resources/data/validator/numeric.mapcss

@@ -67 +67 @@
   assertNoMatch: "node building:levels=0"; /* valid because there can be building:levels:underground > 0 or roof:levels > 0 */
 }
 
-*[roof:height][roof:height =~ /^0*(\.0*)?( (m|ft))?$/][roof:shape=flat] {
+*[roof:height][siunit_length(tag("roof:height")) == 0][roof:shape=flat] {
   throwWarning: tr("{0} is unnecessary for {1}", "{0.tag}", "{2.tag}");
   group: tr("unnecessary tag");
   fixRemove: "{0.key}";

[gaben]

I'd like to run through the files before assigning a milestone, so if anyone find a candidate, just ping me and I'll add it to the patch.

[Famlam]

I'd like to run through the files before assigning a milestone, so if anyone find a candidate, just ping me and I'll add it to the patch.

Another candidate (at the bottom of combinations.mapcss)

area[/^(building|building:part)$/][height =~ /^[0-9]+(\.[0-9]+)?( m)?$/][min_height =~ /^[0-9]+(\.[0-9]+)?( m)?$/][get(split(" ", tag(height)), 0) <= get(split(" ", tag(min_height)), 0)],

Probably (untested) something like:

area[/^(building|building:part)$/][height][min_height][siunit_length(tag(height)) <= siunit_length(tag(min_height))],

[Famlam]

For what it's worth: I didn't find other ones so I think the patch is complete now

[gaben]

I'm on vacation right now, but the patch should be okay.

[stoecker]

In 19140/josm:

adapt height rules to use siunit_length - patch by gaben, fix #23781