Defunct payment methods in preset

[openstreetmap@…]

What steps will reproduce the problem?

1. Open the "Shops/Payment methods" preset dialog

What is the expected result?

The dialog will not list:

• Laser: defunct since March 2014: ​https://en.wikipedia.org/wiki/Laser_(debit_card)
• Minicash: defunct since Nov 2011: ​https://www.wort.lu/luxemburg/bereichern-banken-sich-an-minicash-guthaben/524598.html, or
• Avant (defunct since March 2006: ​https://fi.wikipedia.org/wiki/Avant-kortti ).

I suspect there are more defunct methods (especially among the "Electronic purse" category: I could not find any web results for Mep, Minipay and Mondero 4B still being active), but I could not find proof.

What happens instead?

The dialog shows these defunct methods.

Please provide any additional information below. Attach a screenshot if possible.

Revision:19096
Build-Date:2024-06-04 11:25:36

Identification: JOSM/1.5 (19096 de) Mac OS X 14.5
OS Build number: macOS 14.5 (23F79)
Memory Usage: 480 MB / 4096 MB (223 MB allocated, but free)
Java version: 21.0.3+9-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: Display 1 1470×956 (scaling 2.00×2.00)
Maximum Screen Size: 1470×956
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: de_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=19096, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=/Applications/JOSM.app/Contents/MacOS/JOSM]
Dataset consistency test: No problems found

Tagging presets:
+ https://www.openrailwaymap.org/josm-presets/de-signals-bostrab.zip
+ https://www.openrailwaymap.org/josm-presets/de-signals-eso.zip
+ https://www.openrailwaymap.org/josm-presets/de.zip
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/OpenSeaMap-PresetForSeamarks&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParcelLockers&zip=1

Last errors/warnings:
- 00004.527 E: Detaillierte Information: [Links von Wegrichtung, Rechts von Wegrichtung] <> [left, right, overhead, in_track]
- 00108.588 W: java.net.SocketTimeoutException: Connect timed out
- 00108.589 W: java.net.SocketTimeoutException: Connect timed out
- 00108.589 W: java.net.SocketTimeoutException: Connect timed out
- 00108.589 W: java.net.SocketTimeoutException: Connect timed out
- 00108.589 W: java.net.SocketTimeoutException: Connect timed out
- 00108.589 W: java.net.SocketTimeoutException: Connect timed out
- 00108.589 W: java.net.SocketTimeoutException: Connect timed out
- 00108.589 W: java.net.SocketTimeoutException: Connect timed out
- 00108.590 W: java.net.SocketTimeoutException: Connect timed out

[openstreetmap@…]

I had a look around on TagInfo and Overpass: all of the tags are still in use, but mostly erroneous (payment:ep_minicash has 16 tags outstanding, none of which are in Luxembourg; and payment:ep_avant has 11 tags outstanding, none of which are in Finland). payment:laser still has ~280 uses, ~90% of which are outside Ireland.

[aceman]

So if those payment methods do not work anymore, somebody just forgot to remove them from OSM. They do not need to exist in a preset to encourage adding new ones (possibly by mistake).

[stoecker]

In 19488/josm:

drop outdated payment methods, fix #23724

[stoecker]

In 19491/josm:

fix tests, see #23724