Modify ↓
#23715 closed defect (fixed)
Plugin Relation Toolbox began to remove multipuligons
| Reported by: | afanasovich | Owned by: | Zverikk |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Plugin reltoolbox | Version: | |
| Keywords: | template_report | Cc: |
Description
What steps will reproduce the problem?
- If a multipolygon becomes disconnected during plugin operation (when adding or removing a member of the relation), the plugin deletes the multipolygon relation.
What is the expected result?
Previously, when a broken multipooligon was created, it was not deleted, but there was an option to add/remove its members until the outline was closed.
What happens instead?
Please provide any additional information below. Attach a screenshot if possible.
Revision:18822 Build-Date:2023-08-30 11:44:32 Identification: JOSM/1.5 (18822 ru) Windows 10 64-Bit OS Build number: Windows 10 Enterprise LTSC 2019 1809 (17763) Memory Usage: 1196 MB / 2024 MB (634 MB allocated, but free) Java version: 17.0.8+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel Screen: \Display0 1920×1200 (scaling 1.00×1.00) \Display1 1920×1080 (scaling 1.00×1.00) Maximum Screen Size: 1920×1200 Best cursor sizes: 16×16→32×32, 32×32→32×32 System property file.encoding: Cp1251 System property sun.jnu.encoding: Cp1251 Locale info: ru_RU Numbers with default locale: 1234567890 -> 1234567890 VM arguments: [-Djpackage.app-version=1.5.18822, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe] Dataset consistency test: No problems found Plugins: + FastDraw (36226) + alignways (36205) + buildings_tools (36226) + imagery_offset_db (36226) + josm_magic_wand (2.0.3) + reltoolbox (36241) + utilsplugin2 (36241) + wikipedia (605) Tagging presets: + https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml Map paint styles: - https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1 Last errors/warnings: - 00001.043 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF' - 00001.046 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF' - 00015.503 E: java.security.KeyStoreException: Windows-ROOT not found. Причина: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available - 00559.810 W: java.net.SocketTimeoutException: Connect timed out - 01891.286 W: Несохранённые изменения - <html>Отношение было изменено.<br><br>Вы хотите сохранить изменения?</html>
Attachments (1)
Change History (7)
follow-up: 2 comment:1 by , 5 months ago
comment:2 by , 5 months ago
Replying to GerdP:
Please describe step by step how to reproduce. Maybe this is a regression of my work on the plugin between End of February and March.
- Create any closed polygon, for example, a rectangle with the DrawBuilding tool (key B).
- Select it and convert it into a multipolygon (⌥ + ⌘ + A).
- Create any new segment (key A)
- Select a multipolygon
- In the Toolbox plugin panel, double-click on its name to activate the multipolygon editing mode
- Select a segment
- Add a segment to the multipolygon (⌥ + ⌘ + F1).
After that, the multipolygon will disappear. But it must be preserved, even though it is not closed.
comment:3 by , 5 months ago
Not sure if I see the same problem, but when I add an unclosed way to the relation by clicking on the "+" button the multipolygon relation is changed so that it has no members. The relation itself is not deleted, but empty.
I'll try to find out why this happens...
by , 5 months ago
| Attachment: | 23715.patch added |
|---|
I think this patch will fix the issue (and some similar).
comment:4 by , 5 months ago
I want to add unit tests for this regression but failed to understand the existing ones so far :(
Note:
See TracTickets
for help on using tickets.
Please describe step by step how to reproduce. Maybe this is a regression of my work on the plugin between End of February and March.