Opened 19 months ago
Last modified 10 months ago
#23654 new defect
[WIP patch] Attribution text misalignment
| Reported by: | gaben | Owned by: | team |
|---|---|---|---|
| Priority: | trivial | Milestone: | |
| Component: | JMapViewer | Version: | |
| Keywords: | template_report | Cc: |
Description
What steps will reproduce the problem?
- Open a layer which has an attribution
- Check the alignment on the lower right corner
What is the expected result?
There is even padding around the text
What happens instead?
No padding on the right, makes hard to read the end.
Please provide any additional information below. Attach a screenshot if possible.
Revision:19067
Is-Local-Build:true
Build-Date:2024-05-01 14:57:09
Identification: JOSM/1.5 (19067 SVN en) Linux Ubuntu 22.04.4 LTS
Memory Usage: 386 MB / 3988 MB (79 MB allocated, but free)
Java version: 21.0.2+13-Ubuntu-122.04.1, Private Build, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1912×1020 (scaling 1.00×1.00)
Maximum Screen Size: 1912×1020
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: hu_HU.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_HU
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: ubuntu:GNOME
Java ATK Wrapper package: libatk-wrapper-java:all-0.38.0-5build1
fonts-noto: fonts-noto:-
VM arguments: [--add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, -javaagent:${HOME}/progs/idea/lib/idea_rt.jar=42693:${HOME}/progs/idea/bin, -Dfile.encoding=UTF-8, -Dsun.stdout.encoding=UTF-8, -Dsun.stderr.encoding=UTF-8]
Attachments (4)
Change History (8)
by , 19 months ago
| Attachment: | before.png added |
|---|
by , 19 months ago
comment:1 by , 19 months ago
by , 19 months ago
| Attachment: | josm_23654.patch added |
|---|
comment:2 by , 19 months ago
Marked it as WIP, because I want to understand the attrTermsText printing part, which is probably simplifyable.
by , 10 months ago
| Attachment: | josm_23654_2.patch added |
|---|
comment:3 by , 10 months ago
I left a function (drawRectangleWithBorder()) there for you to test the patch, you should remove it before committing. I tested it myself on the JMapViewer demo, it looked good there.
comment:4 by , 10 months ago
Hmm, I've just realized text aliasing is globally missing from JMapViewer.



It's just 5px padding which is missing.