[patch] Attribution text misalignment

[gaben]

What steps will reproduce the problem?

1. Open a layer which has an attribution
2. Check the alignment on the lower right corner

What is the expected result?

There is even padding around the text

What happens instead?

No padding on the right, makes hard to read the end.

Please provide any additional information below. Attach a screenshot if possible.

Revision:19067
Is-Local-Build:true
Build-Date:2024-05-01 14:57:09

Identification: JOSM/1.5 (19067 SVN en) Linux Ubuntu 22.04.4 LTS
Memory Usage: 386 MB / 3988 MB (79 MB allocated, but free)
Java version: 21.0.2+13-Ubuntu-122.04.1, Private Build, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1912×1020 (scaling 1.00×1.00)
Maximum Screen Size: 1912×1020
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: hu_HU.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_HU
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: ubuntu:GNOME
Java ATK Wrapper package: libatk-wrapper-java:all-0.38.0-5build1
fonts-noto: fonts-noto:-
VM arguments: [--add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, -javaagent:${HOME}/progs/idea/lib/idea_rt.jar=42693:${HOME}/progs/idea/bin, -Dfile.encoding=UTF-8, -Dsun.stdout.encoding=UTF-8, -Dsun.stderr.encoding=UTF-8]

[gaben]

It's just 5px padding which is missing.

[gaben]

Marked it as WIP, because I want to understand the attrTermsText printing part, which is probably simplifyable.

[gaben]

I left a function (drawRectangleWithBorder()) there for you to test the patch, you should remove it before committing. I tested it myself on the JMapViewer demo, it looked good there.

[gaben]

Hmm, I've just realized text aliasing is globally missing from JMapViewer.

[gaben]

I'll commit this version in the next days.

[gaben]

Replying to gaben:

I'll commit this version in the next days.

Cannot commit, credentials problem, whatever. Whoever has right, please commit attachment:josm_23654_3.patch​​ :)

I tested it, results what is in comment:1.

[stoecker]

I added you to osmsvn as well. You should be able to commit now.

[gaben]

Oh okay, thank you! Let's see.

[gaben]

In 36510/osm:

fix #23654 - improve map imagery attribution padding

[stoecker]

Do a new release 2.26?

[gaben]

I was thinking about it, but there might be more to come ;)

I'm currently experimenting with Maven and build stuff. Maybe wait a week or so and if there is nothing, 2.26 can be released.

[gaben]

I found some things, I'll open a new ticket for the findings.

There are minor issues in the demo, and medium issues in the UI scaling, which affects JOSM at the end. I created a fix, that supposed to resolve the problems, but not everything propagates and possibly breaking, so testing currently, besides the 5-6 ongoing, not yet published patches.