Modify

Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#23652 closed defect (fixed)

Wrong warning for elevator

Reported by: GerdP Owned by: team
Priority: normal Milestone: 24.04
Component: Core validator Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Have a node with highway=elevator that connects a footway on layer 0 with a bridge on layer 1, e.g. https://www.osm.org/node/5643402057
  2. run validator

What is the expected result?

No warning

What happens instead?

Warning "Node connects highways on different layers"

Please provide any additional information below. Attach a screenshot if possible.

Regression of #9304. I think this is valid.

Revision:19067
Is-Local-Build:true
Build-Date:2024-04-30 07:02:46

Identification: JOSM/1.5 (19067 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 22H2 (19045)
Memory Usage: 1876 MB / 1888 MB (1190 MB allocated, but free)
Java version: 17.0.5+8, Eclipse Adoptium, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_DE
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (36258)
+ RoadSigns (36258)
+ apache-commons (36176)
+ buildings_tools (36226)
+ comfort0 (36200)
+ ejml (36176)
+ geotools (36176)
+ jackson (36176)
+ jaxb (36118)
+ jts (36004)
+ o5m (36126)
+ opendata (36256)
+ pbf (36176)
+ poly (36126)
+ reltoolbox (36241)
+ reverter (36256)
+ undelete (36226)
+ utilsplugin2 (36241)

Tagging presets:
+ c:\josm\core\resources\data\defaultpresets.xml

Validator rules:
+ d:\java_tools\JOSM\mygeometry.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1
+ c:\josm\core\resources\data\validator\combinations.mapcss
+ c:\josm\core\resources\data\validator\geometry.mapcss
+ d:\java_tools\JOSM\myhnr.mapcss

Last errors/warnings:
- 00000.565 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.568 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 01898.191 E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<You requested too many nodes (limit is 50000). Either request a smaller area, or use planet.osm>
- 01898.198 E: Bad Request - <html>The OSM server 'api.openstreetmap.org' reported a bad request.<br><br>The area you tried to download is too big or your request was too large.<br>Either request a smaller area or use an export file provided by the OSM community.</html>
- 04114.896 W: org.openstreetmap.josm.plugins.ohe.parser.TokenMgrError: Lexical error at line 1, column 1.  Encountered: 'P' (80),
- 04119.968 W: Disable opening hours editor:: org.openstreetmap.josm.plugins.ohe.gui.OheException: Error in the TimeValue. Cause: org.openstreetmap.josm.plugins.ohe.parser.TokenMgrError: Lexical error at line 1, column 1.  Encountered: 'P' (80),
- 04152.701 W: org.openstreetmap.josm.plugins.ohe.parser.TokenMgrError: Lexical error at line 1, column 1.  Encountered: 'P' (80),
- 04166.493 W: Disable opening hours editor:: org.openstreetmap.josm.plugins.ohe.gui.OheException: Error in the TimeValue. Cause: org.openstreetmap.josm.plugins.ohe.parser.TokenMgrError: Lexical error at line 1, column 1.  Encountered: 'P' (80),
- 13819.653 W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
- 14377.528 W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>

Change History (3)

comment:1 by GerdP, 13 months ago

Component: CoreCore validator
Summary: Wrong warningWrong warning for elevator

comment:2 by GerdP, 13 months ago

Resolution: fixed
Status: newclosed

In 19068/josm:

fix #23652 Wrong warning for elevator

  • don't check different layers when the node is tagged with highway=elevator

comment:3 by GerdP, 13 months ago

Milestone: 24.04

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.