Modify

Opened 12 months ago

Closed 6 months ago

#23646 closed defect (invalid)

[PATCH] Dont warn parking=* on bicycle_parking

Reported by: Tjuro Owned by: Tjuro
Priority: normal Milestone:
Component: Core validator Version:
Keywords: bicycle_parking parking Cc:

Description

When adding parking to bicycle_parking for example to differentiate surface parking from street parking.

An warning is thrown. I think that a the validator rule: "missing tag - parking without amenity=parking etc" should include amenity=bicycle_parking

Attachments (1)

bicycle_parking.patch (925 bytes ) - added by Pintoch 6 months ago.
patch which addresses the issue

Download all attachments as: .zip

Change History (6)

comment:1 by anonymous, 12 months ago

Priority: normalmajor
Type: enhancementdefect

by Pintoch, 6 months ago

Attachment: bicycle_parking.patch added

patch which addresses the issue

comment:2 by Pintoch, 6 months ago

Summary: Dont warn parking=* on bicycle_parking[PATCH] Dont warn parking=* on bicycle_parking

comment:3 by skyper, 6 months ago

Owner: changed from team to Tjuro
Priority: majornormal
Status: newneedinfo

According to tags/amenity=bicycle_parking#combinations this combination is not in use.
The additional tag for amenity=bicycle_parking is bicycle_parking=* and I do not think we need to separate "surface parking" from "street parking" as there is no tagging system for bicycle parking on highway=*.

comment:4 by Pintoch, 6 months ago

Ah, that makes sense - I made this patch for the sake of attempting to tackle a JOSM ticket, without having the necessary tagging knowledge to confirm the soundness of the request. Sorry about that!
Your assessment of the situation looks convincing to me, it's probably worth closing this ticket.

in reply to:  4 comment:5 by skyper, 6 months ago

Keywords: bicycle_parking parking added
Resolution: invalid
Status: needinfoclosed
Version: latest

Replying to Pintoch:

Ah, that makes sense - I made this patch for the sake of attempting to tackle a JOSM ticket, without having the necessary tagging knowledge to confirm the soundness of the request. Sorry about that!

Thanks for contributing to JOSM and I am sorry that I missed to comment on this ticket earlier. Bad luck.
It is always worth to take a look at taginfo and the wiki when fixing or updating validator rules and presets.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Tjuro.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.