Opened 12 months ago
Closed 6 months ago
#23646 closed defect (invalid)
[PATCH] Dont warn parking=* on bicycle_parking
Reported by: | Tjuro | Owned by: | Tjuro |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core validator | Version: | |
Keywords: | bicycle_parking parking | Cc: |
Description
When adding parking to bicycle_parking for example to differentiate surface parking from street parking.
An warning is thrown. I think that a the validator rule: "missing tag - parking without amenity=parking etc" should include amenity=bicycle_parking
Attachments (1)
Change History (6)
comment:1 by , 12 months ago
Priority: | normal → major |
---|---|
Type: | enhancement → defect |
by , 6 months ago
Attachment: | bicycle_parking.patch added |
---|
comment:2 by , 6 months ago
Summary: | Dont warn parking=* on bicycle_parking → [PATCH] Dont warn parking=* on bicycle_parking |
---|
comment:3 by , 6 months ago
Owner: | changed from | to
---|---|
Priority: | major → normal |
Status: | new → needinfo |
According to tags/amenity=bicycle_parking#combinations this combination is not in use.
The additional tag for amenity=bicycle_parking
is bicycle_parking=*
and I do not think we need to separate "surface parking" from "street parking" as there is no tagging system for bicycle parking on highway=*
.
follow-up: 5 comment:4 by , 6 months ago
Ah, that makes sense - I made this patch for the sake of attempting to tackle a JOSM ticket, without having the necessary tagging knowledge to confirm the soundness of the request. Sorry about that!
Your assessment of the situation looks convincing to me, it's probably worth closing this ticket.
comment:5 by , 6 months ago
Keywords: | bicycle_parking parking added |
---|---|
Resolution: | → invalid |
Status: | needinfo → closed |
Version: | latest |
Replying to Pintoch:
Ah, that makes sense - I made this patch for the sake of attempting to tackle a JOSM ticket, without having the necessary tagging knowledge to confirm the soundness of the request. Sorry about that!
Thanks for contributing to JOSM and I am sorry that I missed to comment on this ticket earlier. Bad luck.
It is always worth to take a look at taginfo and the wiki when fixing or updating validator rules and presets.
patch which addresses the issue