"Restart JOSM" does not actually restart.

[t-matsuu]

What steps will reproduce the problem?

1. Start JOSM
2. Change language on JOSM and click "OK"
3. Dialog for restart JOSM is shown and click "Restart"

What is the expected result?

Automatically restart.

What happens instead?

Not automatically restart.

Please provide any additional information below. Attach a screenshot if possible.

If this dialog means a manual restart, the dialog message should be changed accordingly.

Revision:19039
Build-Date:2024-04-10 13:32:33

Identification: JOSM/1.5 (19039 ja) Windows 11 64-Bit
OS Build number: Windows 10 Pro 2009 (22631)
Memory Usage: 494 MB / 4006 MB (120 MB allocated, but free)
Java version: 21.0.2+13-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1200 (scaling 1.25×1.25)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: MS932
Locale info: ja_JP
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.19039, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]

Plugins:
+ apache-commons (36176)
+ ejml (36176)
+ geotools (36176)
+ jackson (36176)
+ jaxb (36118)
+ jts (36004)
+ opendata (36200)
+ pmtiles (36219)
+ utilsplugin2 (36241)

Tagging presets:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/JP.zip

Map paint styles:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_PAC.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1

Last errors/warnings:
- 00000.440 W: extended font config - overriding 'filename.Malgun_Gothic=malgun.ttf' with 'MALGUN.TTF'
- 00000.442 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.443 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00000.889 E: java.security.KeyStoreException: Windows-ROOT not found. 原因: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available

[GerdP]

I cannot reproduce this on Windows 10. I tried both with Open Webstart and with the command line, JOSM restart works as expected.
How do you recognize that it is not restarted?

[t-matsuu]

1. Click "Restart"
2. Wait for a moment, and then JOSM does not start again
3. Check task manager
4. No JOSM jobs found

I can reproduce this with MSI installer version of JOSM on Windows 11.

[GerdP]

OK, I can reproduce with the MSI installer (both with JOSM.exe and JOSM HWConsole.exe). Josm stops but doesn't restart.
I am pretty sure that this worked before I installed (again) with the current tested *.msi package.

[GerdP]

Might be a regression of #23552.

[GerdP]

A bit more info: I've uninstalled JOSM and used josm-setup.exe from August 2023 to install. With that version (r18789) the restart works. It also works when I modify HWConsole.cfg to start the current tested version r19039 from https://josm.openstreetmap.de/josm-tested.jar.
Can't do much more here.

[SOUGrOjj2Ppa4zMrmfv]

I've bisected by testing the provided versions on GitHub.
The last working version is ​https://github.com/JOSM/josm/releases/tag/18939.
The first broken version is ​https://github.com/JOSM/josm/releases/tag/18940.
​https://github.com/JOSM/josm/compare/18939...18940

[GerdP]

I cannot reproduce the problem with r19039, so I wonder what your test is about?

[taylor.smock]

I'm a bit confused. If I understood the problem, JOSM doesn't restart when File -> Restart is called; it just stops.
Anyway, if I understood the problem, it stopped working between r18940 and r18941. Which is fun, since neither one should have affected restart.

I'm betting it is a Java version issue.

r18940 was built with Azul Java 21.0.1+12.
r18941 was built with Azul Java 21.0.2+13.

[taylor.smock]

Upstream ticket: ​JDK-8325924

[GerdP]

I don't think that it is related to josm.jar. I think it is the wrapper program josm.exe.

[SOUGrOjj2Ppa4zMrmfv]

I did a bit more testing.

I actually had tested ​18940-tested as 18940 not ​18940. That's why my findings were not as expected by the Java version change.

	Java 17		Java 21		Java 22
​18939	working	17.0.9	working	21.0.1	not working	22-beta
​18940	working	17.0.9	working	21.0.1	not working	22-beta
​18940-tested	not working	17.0.10	not working	21.0.2	not working	22-beta
​18941	not working	17.0.10	not working	21.0.2	not working	22-beta
​19040	not working	17.0.10	not working	21.0.2	not working	22

[GerdP]

I don't get it. I can restart old and new JOSM versions with the older JOSM.exe, but not with the one that is now in the *.msi package.

[taylor.smock]

As I noted in comment:9 and comment:10, I believe this is a Java bug. Specifically, I think it is a problem with either with jpackage which is what builds the binaries that start the jar or with the JDK. Either way, the problem isn't in our code (maybe I could have made this a bit clearer?).

Anyway, thanks go to @SOUGrOjj2Ppa4zMrmfv for helping us with this investigation.

I don't think we want to roll back to an older Java version right now. Maybe if there is something truly breaking instead of just inconvenient.

[GerdP]

OK, now I understand. I was not aware that JOSM.exe is produced with a JDK.

[GerdP]

Ticket #23737 has been marked as a duplicate of this ticket.

[BrackoNe]

Sorry for the duplication. I have installed exe file (not MSI) and have the same issue. Windows 11 Operating system.
It is really frustrating when creating MapStyle and it requires many restarts.

[t-matsuu]

Replying to taylor.smock:

Upstream ticket: ​JDK-8325924

The bug has been fixed as a duplicate of ​JDK-8325203 and it has been fixed upstream.
22.0.1 was released on 2024-04-16.
17.0.12 and 21.0.4 are planned for 2024-07-16.

[GerdP]

As a work around you can start JOSM from the command line:

cd %LOCALAPPDATA%\josm\runtime\bin
java --add-exports=java.base/sun.security.action=ALL-UNNAMED --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED -jar "..\..\app\josm-custom.jar"

[skyper]

Replying to BrackoNe:

Sorry for the duplication. I have installed exe file (not MSI) and have the same issue. Windows 11 Operating system.

No problem

It is really frustrating when creating MapStyle and it requires many restarts.

Why do you need to restart? You should be able to reload the file using the context menu in the Map Paint Panel

[BrackoNe]

Sometimes it doesn’t want to load all new images, and/or interface doesn’t behave as expected, so I’m forced to make the restart.

[skyper]

I see.
In #10420 there is a link to Styles/IconTester where it is suggested to rename the icon if you change it.
Regarding the interface, it would be nice to know exactly what is causing problems. I only find a few tickets describing problems on reload. Feel free to comment and/or create a new ticket.

[anonymous]

I’m planning next few days to play around with my style ​https://github.com/BrackoNe/rs_traffic_signs.
As soon as I find same issue, I’ll make scrns and create a new bug.

[taylor.smock]

Ticket #23805 has been marked as a duplicate of this ticket.

[skyper]

Meanwhile, Azul has released version 21.0.4+7. See #23919.