Modify

Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#23579 closed defect (duplicate)

Counterproductive combine ways dialogue. Missing tags should not be considered a conflict.

Reported by: InsertUser Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: replace geometry, conflicts Cc:

Description

If a user attempts to merge two features, such as a POI or address mapped as a node with a newly created building outline (via CTRL+SHIFT+G) they now have to manually select every single value for every single tag whether or not they actually contain conflicting values in the two entities to be merged.

As an example:
A newly drawn building:

Way: -606
  Tags: 
    "building"="yes"

To be merged with a previously created POI:

Node: <some positive number>
  Tags: 
    "addr:housenumber"="1"
    "addr:street"="Fakestreet"
    "addr:city"="Exampletown"
    "website"="https://www.example.com"
    "phone"="+1 555 555 5505"
    "shop"="alcohol"
    "name"="An Exemplary Grocery Store"
    "wheelchair"="yes"

After the keyboard shortcut to replace geometry:

  1. The user has to click on the dropdown menu for "addr:city"
  2. The user has to click on "Exampletown"
  3. The user has to click on the dropdown menu for "addr:housenumber"
  4. The user has to click on "1"
  5. The user has to click on the dropdown menu for "addr:street"
  6. The user has to click on "Fakestreet"
  7. The user has to click on the dropdown menu for "building"
  8. The user has to click on "yes"
  9. The user has to click on the dropdown menu for "phone"
  10. The user has to click on "+1 555 555 5505"
  11. The user has to click on the dropdown menu for "shop"
  12. The user has to click on "alcohol"
  13. The user has to click on the dropdown menu for "name"
  14. The user has to click on "An Exemplary Grocery Store"
  15. The user has to click on the dropdown menu for "wheelchair"
  16. The user has to click on "yes"

This is incredibly tedious. There is no option to automatically select the non-"none" option if there is no actual conflict, and neither of the tickboxes at the top do anything useful in this scenario.

I think this is encouraging users to not keep the history and not be aware of any conflicts as it is now easier to copy the POI to clipboard, completely delete it and CTRL+SHIFT+V the old tags onto the new way. This methos does not bring up a dialogue if one of the tags you are pasting overrides an existing tag, which would mean that the conflict dialogue is actively working against its intended purpose.

Please add a tickbox to default to using the only value present for a tag if the only other option is to delete that data.

Attachments (0)

Change History (4)

comment:1 by GerdP, 13 months ago

Resolution: duplicate
Status: newclosed

Closed as duplicate of #23555.
see #23305 for why and #23555 for further discussion. It was already decided that the change will be reverted.

comment:2 by GerdP, 13 months ago

Just as a remark: If you draw a new way which should replace another it is better to have the new way untagged before the replace action and maybe add further tags after. That also avoids the dialog when the old way also has a building=* tag, but a different one.

comment:3 by InsertUser, 13 months ago

And if, as in the actual example I gave, you are replacing a point with an outline, you are likely to have tags on the new way already. Ones that aren't in conflict because they don't exist on the point feature.

If I was combining ways that legitimately had different values for the building key then this dialogue would actually be doing something useful, which is the reason I didn't complain about cases where there is an actual conflict in the tagging.

comment:4 by GerdP, 13 months ago

So, if you want to stick to that workflow just set the preference combine-conflict-precise=false

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.