JOSM freezes for multiple seconds when selecting any object

[swedneck]

What steps will reproduce the problem?

1. have a layer with at least one object, even a single untagged node
2. select any object

(3.) there seems to be some unknown condition that has to be met for this to occur, and this condition will seemingly randomly occur at any time (possibly linked to loading a data file? very unsure) and last for a varying amount of time (from perhaps a minute or so, up to long enough that i give up and try again the next day)

What is the expected result?

Not freezing up

What happens instead?

The entire application freezes for several seconds, then resumes with the object(s) successfully selected like normal.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-07-06 21:00:41 +0200 (Thu, 06 Jul 2023)
Revision:18772
Build-Date:2023-07-07 01:30:58
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18772 en) Linux Fedora Linux 38 (Workstation Edition)
Memory Usage: 1300 MB / 8004 MB (308 MB allocated, but free)
Java version: 17.0.9+9, Red Hat, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.gtk.GTKLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00) :0.1 1920×1080 (scaling 1.00×1.00) :0.2 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: sv_SE.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: XFCE
Java package: java-17-openjdk:x86_64-17.0.9.0.9
apache-commons-compress: apache-commons-compress:noarch-1.21
apache-commons-logging: apache-commons-logging:noarch-1.2
VM arguments: [--module-path=/usr/share/openjfx/lib, -Djosm.restart=true, -Djava.net.useSystemProxies=true, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED]
Dataset consistency test: No problems found

Plugins:
+ ColorPlugin (v1.1.2.1)
+ FastDraw (36097)
+ ImproveOsm (238)
+ ImproveWay (32)
+ Mapillary (2.1.5)
+ PicLayer (1.0.2)
+ SimplifyArea (36097)
+ apache-commons (36034)
+ apache-http (35924)
+ areaselector (1652822522)
+ austriaaddresshelper (master-4e80dc2e4261d321150187f4951684ad97342d5e)
+ buildings_tools (36097)
+ ejml (35924)
+ geotools (36068)
+ gridify (1606242219)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jogl (1.2.3)
+ jts (36004)
+ log4j (36045)
+ measurement (36097)
+ opendata (36097)
+ pt_assistant (2.1.15-19-g9aeec3c-SNAPSHOT)
+ public_transport (36097)
+ reltoolbox (36097)
+ shrinkwrap (v1.0.4)
+ splinex (36097)
+ tageditor (36097)
+ todo (128)
+ turnlanes-tagging (0.0.5)
+ utilsplugin2 (36097)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Leaftype&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportGtfs&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/SE.zip

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&zip=1
- https://raw.githubusercontent.com/yopaseopor/indoormap/master/indoormap-style.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Bench&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/light_source&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1
- https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR_OR.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Lit&zip=1
- https://raw.githubusercontent.com/OpenSidewalks/OpenSidewalks-Schema/master/open_sidewalks.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleBuildingTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksAndFootways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/iD&zip=1
- ${HOME}/Downloads/drawing.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
+ ${HOME}/Downloads/custom bus routes.mapcss

Last errors/warnings:
- 00204.711 E: Failed to locate image 'https://vbk.lansstyrelsen.se/Content/images/logo.png'
- 00204.872 E: Failed to locate image 'https://scb.se/StyleguideAssets/scb/img/Start//favicon-32x32.png'
- 00205.028 E: Failed to locate image 'https://scb.se/StyleguideAssets/scb/img/Start//favicon-32x32.png'
- 00205.190 E: Failed to locate image 'https://scb.se/StyleguideAssets/scb/img/Start//favicon-32x32.png'
- 00205.347 E: Failed to locate image 'https://scb.se/StyleguideAssets/scb/img/Start//favicon-32x32.png'
- 00240.045 E: Failed to locate image 'https://vbk.lansstyrelsen.se/Content/images/logo.png'
- 00240.234 E: Failed to locate image 'https://scb.se/StyleguideAssets/scb/img/Start//favicon-32x32.png'
- 00240.394 E: Failed to locate image 'https://scb.se/StyleguideAssets/scb/img/Start//favicon-32x32.png'
- 00240.546 E: Failed to locate image 'https://scb.se/StyleguideAssets/scb/img/Start//favicon-32x32.png'
- 00240.705 E: Failed to locate image 'https://scb.se/StyleguideAssets/scb/img/Start//favicon-32x32.png'

[taylor.smock]

@swedneck: Can you please update JOSM and its plugins? You have some old versions in there. It really isn't worth my time to try and debug something that is that far out of date, especially since I have done a lot of perf improvements since then. Which may fix your issue, if it is not the same as #23553.

Specifically,

Revision:18772

r18772 is from 2023-07-06.

Once you have updated and reproduced, comment:2:ticket:23553 has some instructions on how to get a thread dump.

[taylor.smock]

Side note: I'm suspecting the problem is shrinkwrap. You can try disabling it to see if that fixes the problem.

[taylor.smock]

Closed as duplicate of #23553.
It looks like it is a problem with shrinkwrap. I just loaded a large area (​https://www.openstreetmap.org/relation/1411341) into JOSM and clicked on a node. It took quite some time for JOSM to become responsive again.

[swedneck]

Replying to taylor.smock:

Closed as duplicate of #23553.
It looks like it is a problem with shrinkwrap. I just loaded a large area (​https://www.openstreetmap.org/relation/1411341) into JOSM and clicked on a node. It took quite some time for JOSM to become responsive again.

i just want to point out that it has no relation to the size of the selection, this happens even if the only object is a single untagged node.

[taylor.smock]

I that that is what I said? Maybe I just wrote it badly.

Anyway, when I profiled selecting a node, in comment:3, 7.5s was spent (total -- I changed the selected object a few times) in BalloonAction#updateEnabledState.