JOSM freezes when pulling from the National Address Database

[xem0861@…]

What steps will reproduce the problem?

1. Downloading a area of OSM data
2. Attempting to pull NAD data from the MapWithAI plugin

What is the expected result?

A new layer with address nodes from the National Address Database

What happens instead?

JOSM freezes to freezes to a point where I have to end task via task manager to restart it. I've waited up to 12 hrs for it to unfreeze but it never did.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2024-02-05 12:56:34 +0100 (Mon, 05 Feb 2024)
Revision:18969
Build-Date:2024-02-06 02:30:58
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18969 en) Windows 11 64-Bit
OS Build number: Windows 10 Home 2009 (22621)
Memory Usage: 1126 MB / 4062 MB (528 MB allocated, but free)
Java version: 21.0.1+12-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatDarkLaf
Screen: \Display0 1920×1080 (scaling 1.00×1.00) \Display1 1680×1050 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=%UserProfile%\AppData\Local\Programs\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop, -Djava.security.manager=allow]

Plugins:
+ CADTools (1008)
+ ImproveOsm (238)
+ apache-commons (36176)
+ apache-http (36176)
+ auto_tools (81)
+ buildings_tools (36200)
+ conflation (0.6.11)
+ continuosDownload (103)
+ easypresets (1623509627)
+ ejml (36176)
+ flatlaf (36036)
+ geotools (36176)
+ jackson (36176)
+ jaxb (36118)
+ jna (36176)
+ jts (36004)
+ mapwithai (827)
+ opendata (36200)
+ pmtiles (36156)
+ public_transport (36200)
+ todo (137)
+ undelete (36126)
+ utilsplugin2 (36200)
+ wikipedia (605)

Tagging presets:
+ <josm.pref>/EasyPresets.xml
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Last errors/warnings:
- 00003.615 W: Failed to scan file 'ImproveOsm.jar.new' for plugin information. Skipping.
- 00004.885 W: java.util.zip.ZipException: zip file is empty
- 00004.886 W: PluginException: : org.openstreetmap.josm.plugins.PluginException: Invalid jar file '<josm.pref>\plugins\ImproveOsm.jar.new'
- 00004.886 W: Failed to scan file 'ImproveOsm.jar.new' for plugin information. Skipping.
- 00005.083 E: org.openstreetmap.josm.plugins.PluginDownloadException: java.nio.file.FileSystemException: <josm.pref>\plugins\flatlaf.jar.new: The process cannot access the file because it is being used by another process. Cause: java.nio.file.FileSystemException: <josm.pref>\plugins\flatlaf.jar.new: The process cannot access the file because it is being used by another process
- 00006.477 E: org.openstreetmap.josm.plugins.PluginDownloadException: java.io.IOException: stream is closed. Cause: java.io.IOException: stream is closed
- 00006.504 E: Plugin update failed - <html>Updating the following plugins has failed:<ul><li>flatlaf</li><li>ImproveOsm</li></ul>Please open the Preference Dialog after JOSM has started and try to update them manually.</html>
- 00018.689 W: Failed to delete outdated plugin '<josm.pref>\plugins\flatlaf.jar'.
- 00018.690 W: Failed to install already downloaded plugin 'flatlaf'. Skipping installation. JOSM is still going to load the old plugin version.
- 00018.690 W: Failed to install plugin '<josm.pref>\plugins\ImproveOsm.jar' from temporary download file '<josm.pref>\plugins\ImproveOsm.jar.new'. zip file is empty: java.util.zip.ZipException: zip file is empty

[taylor.smock]

@xem0861: Can you give me the download area? I haven't been able to reproduce. You can get the area from osm-download.bounds in advanced preferences.

[Isaiah B <xem0861@…>]

I think this is it.

41.9073076;-88.7688855;41.9091392;-88.7520474

Just to let you know, yesterday I tried installing JOSM and plugins on a new laptop and I get the same results.

[taylor.smock]

I'm thinking this might be a bad interaction between continuousDownload and MapWithAI. I haven't been able to get it to freeze though. It might be a Windows specific issue.

If you don't mind doing some stuff on your end, can you get a thread dump?

Steps to get a thread dump:

1. Install a JDK (​https://adoptium.net/temurin/releases/?version=21&os=windows&arch=x64&package=jdk or ​https://www.azul.com/downloads/?version=java-21-lts&os=windows&architecture=x86-64-bit&package=jdk-fx#zulu )
2. Get the process id with jps. Look for MainApplication, JOSM, or Boot -- I'm not certain what is going to be shown on Windows.

Example output:

$ jps
34000 Main
66850 Jps
66836 josm-tested.jar
13862 Main
65151 Launcher

3. Using the process id from (2), get the stack trace with jstack.

Example:

$ jstack 66836
2024-03-04 10:04:28
Full thread dump OpenJDK 64-Bit Server VM (21.0.2+13-LTS mixed mode, sharing):

[...and a whole bunch of text; copy and paste either into this ticket or a new notepad document and upload the document...]

[Isaiah B <xem0861@…>]

I installed the JDK however I am unable to find the process ID using task manager.

[taylor.smock]

You can get the process ID using jps on the command line. I don't recall whether or not the Windows Task Manager has the ability to get the process id.

[Isaiah B <xem0861@…>]

Ok so the process ID is 10028, I put in jstack 10028 I get this:

C:\Users\ibert>jstack 10028
10028: no such process

[taylor.smock]

Did you close JOSM? I assume you didn't, but just in case.

If not, can you copy/paste the output of jps here?

[Isaiah B <xem0861@…>]

I tried with JOSM both open and closed I still get "no such process"

[taylor.smock]

I feel like we might be communicating past each other.
Can you upload screenshots from jps and jstack?

The ids from jps are not persistent, so if you ran jps once, and then reused the same process id, that might be the problem. I assume you ran jps when you had the JOSM instance you were getting the thread dump from open, and then ran jstack with that process id while the JOSM instance was open.

[Isaiah B <xem0861@…>]

I found out the issue i think, The process ID is changing before i get the jstack command typed out. I entered the jps

a few times in a row and every time it was something else.

[taylor.smock]

That is odd. On a per JOSM instance basis, it should be static.

[Isaiah B <xem0861@…>]

josm thread_dump_3-8-24

[Isaiah B <xem0861@…>]

I reinstalled the jdk and got the thread dump while JOSM was open. I attached it in a text file.

[taylor.smock]

Was attachment:thread_dump_3-8-24.txt​ from a JOSM version that was frozen?

The UI thread was not blocked in that dump.

[Isaiah B <xem0861@…>]

this one is from while it was frozen

[taylor.smock]

Thanks for getting back to me.

That was a useful thread dump. I'll see if I can get a fix out today this issue.

[taylor.smock]

Should be fixed in ​v829.