Modify

Opened 15 years ago

Closed 15 years ago

#2343 closed defect (fixed)

[PATCH] Area joining fails with special setup

Reported by: stoecker Owned by: xeen
Priority: minor Milestone:
Component: Plugin Version:
Keywords: Cc:

Description

When joining the two ways 24925550 and 23333420 the tool to join areas forgets one line.

Attachments (3)

Adjacent Areas Testcase.osm (3.0 KB ) - added by xeen 15 years ago.
Fix JoinAreas.patch (7.4 KB ) - added by xeen 15 years ago.
Update JoinAreas Testfile.patch (66.2 KB ) - added by xeen 15 years ago.

Download all attachments as: .zip

Change History (5)

by xeen, 15 years ago

Attachment: Adjacent Areas Testcase.osm added

by xeen, 15 years ago

Attachment: Fix JoinAreas.patch added

comment:1 by xeen, 15 years ago

Summary: Area joining fails with special setup[PATCH] Area joining fails with special setup

The patch fixes the following:

  • Undo/Redo action description wasn't really translatable due to area names being included in the String.
  • Prevents duplicates when searching for inner ways
  • Fixed the issue here by explicitly working around it (normally the missing piece should be combined with the outer way, but since this only happens for two-node ways and since it's hard to find those "useful" two-nodes ways, it simply connects first and last node of the outer way which achieves the same).
  • Adds more checks for uninteresting/wrong ways when fixing multipolygons (it sometimes broke the testcase in the lower middle).
  • Made makeCommitsOneAction not produce an error if for some reason the action count is longer than the undo buffer.

comment:2 by stoecker, 15 years ago

Resolution: fixed
Status: newclosed

in [o14356].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain xeen.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.