JOSM opens more image tabs than expected

[GerdP]

What steps will reproduce the problem?

See also #23362, this is probably a side effect of my trying to test those changes.

1. start latest JOSM with a clean home dir.
2. Maximize window for JOSM
3. drag&drop an image which has geo info (call it "1")
4. drag&drop two images ("1" again and another one, call it "2") to a 2nd layer.
5. click on the icon for image "1"

What is the expected result?

The image dialog shows image "1"

What happens instead?

The image dialog shows 2 tabs, one tab possibly containing a different image or both show "1"

Please provide any additional information below. Attach a screenshot if possible.

I think this problem only occurs when the same image appears in more than one layer, but I am not yet sure.
I didn't intent to load the same image twice, still it might happen to other users as well.
It seems to be important wether or not the images are already georeferenced. I see different behaviour when I drop a single image without geo info, JOSM immediately opens the image dialog and another one which tries to correlated a (non existing) gps track with the image.
If collection of dropped images contains at least one image with geo info no window is openend. Not sure if this is intended? Maybe the window(s) are only opened for a fraction of a second but some variables store the never shown picture name as "last viewed"?

I noticed this problem also with a saved session file. Maybe that also contains one or more images in multiple layers. I'll try to find out later.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2024-01-03 16:22:55 +0100 (Wed, 03 Jan 2024)
Revision:18934
Build-Date:2024-01-04 02:31:00
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18934 de) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 382 MB / 1972 MB (128 MB allocated, but free)
Java version: 17.0.8+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: de_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18789, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\HWConsole.exe]

Last errors/warnings:
- 00000.524 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.526 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00000.916 E: java.security.KeyStoreException: Windows-ROOT not found. Ursache: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available

[GerdP]

Hint: It seems to depend on the distance of the geo locations of image "1" and "2".
If I drop two images with exactly the same lat + lon values (my fone creates them like this) JOSM shows both images when I click once.
If I drop two images with cleary different lat+lon JOSM shows the same image in two tabs.
So, all this is not obviously wrong but still quite confusing, esp. because the different image layers all have the same generated name "Georeferenzierte Bilder". Better would be "Georeferenzierte Bilder 1" and ""Georeferenzierte Bilder 2" and so on as with data layers.

[GerdP]

I just learned that this is not a new problem. Happens also with older versions, e.g. r18772.

[GerdP]

When do we set version to latest? When it

• also is reproducible with latest and with tested or
• only with latest and not with tested?

[skyper]

Replying to GerdP:

When do we set version to latest? When it

• also is reproducible with latest and with tested or
• only with latest and not with tested?

Good question. Personally, I set it according to the status report but it rapidly changes anyway from latest to tested to old and I have the feeling this version info is not much useful compared to the version number from the status report.

[GerdP]

I thought it should only be set to latest when it is not reproducible with tested. Since that means that it is very likely a regression of a recent change and thus easier to fix AND of higher priority.

[skyper]

See #23398.

[GerdP]

I think the behaviour is intended and I see no better way to handle the case that the same geolocation is found in different image layers.