Modify

Opened 13 months ago

Last modified 10 months ago

#23327 new enhancement

[patch] enhancement: switch between preview and before in simplify

Reported by: dieterdreist Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: simplify Cc:

Description

Currently, the simplify function shows the result of the simplify even before you apply it (that's nice). It would be even nicer to have a checkbox "show effect" (could be on by default), so switching between the before and after view would be much easier (now you can do it by applying it and then undo/redo, but to change the parameters you have to call the function again).

Attachments (2)

josm_23327.patch (1.7 KB ) - added by gaben 13 months ago.
initial patch
josm_23327v2.patch (1.5 KB ) - added by gaben 13 months ago.
remove preferences config, add javadoc

Download all attachments as: .zip

Change History (7)

by gaben, 13 months ago

Attachment: josm_23327.patch added

initial patch

by gaben, 13 months ago

Attachment: josm_23327v2.patch added

remove preferences config, add javadoc

comment:1 by gaben, 13 months ago

Summary: enhancement: switch between preview and before in simplify[patch] enhancement: switch between preview and before in simplify

comment:2 by taylor.smock, 10 months ago

Milestone: 24.02

Looks good to me. I just want to do a performance check against a large way (2k nodes) and/or against a lot of objects.

comment:3 by taylor.smock, 10 months ago

Milestone: 24.02

I found an issue during testing.

Specifically, increasing/decreasing the threshold would enable the preview mode again.

comment:4 by gaben, 10 months ago

I cannot remember now, but maybe it's a feature. Is it unwanted?

comment:5 by taylor.smock, 10 months ago

That is a good question. It isn't what I expected. I would have expected that setting to persist, especially when the user has a lot of data selected.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to dieterdreist.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.