Modify ↓
Opened 2 years ago
Closed 2 years ago
#23265 closed defect (fixed)
Bad "tag2link" links for key mapillary
| Reported by: | pyrog | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core tag2link | Version: | |
| Keywords: | template_report | Cc: |
Description
What steps will reproduce the problem?
- upload object https://www.openstreetmap.org/node/11307047872
- select it
- right click on mapillary tag
What is the expected result?
Display a link "Open mapillary.com"
What happens instead?
Display two links:
Please provide any additional information below. Attach a screenshot if possible.
URL formatters:
- https://wiki.openstreetmap.org/wiki/Item:Q401#P8
- https://www.wikidata.org/wiki/Property:P1947#P1630
Revision:18822
Build-Date:2023-08-30 11:52:18
Identification: JOSM/1.5 (18822 en_GB) Mac OS X 12.6.7
OS Build number: macOS 12.6.7 (21G651)
Memory Usage: 1945 MB / 2048 MB (556 MB allocated, but free)
Java version: 17.0.8+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 69732928 1280×800 (scaling 2.00×2.00)
Maximum Screen Size: 1280×800
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=18822, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=/Applications/JOSM.app/Contents/MacOS/JOSM]
Dataset consistency test: No problems found
Plugins:
+ Mapillary (2.2.0)
+ PicLayer (1.0.3)
+ apache-commons (36034)
+ apache-http (35924)
+ buildings_tools (36134)
+ cadastre-fr (36126)
+ conflation (0.6.11)
+ continuosDownload (102)
+ contourmerge (v0.2.0)
+ ejml (35924)
+ geotools (36068)
+ jackson (36034)
+ javafx (36118)
+ jaxb (36118)
+ jna (36126)
+ jts (36004)
+ log4j (36045)
+ mbtiles (v2.6.1)
+ opendata (36126)
+ photo_geotagging (36126)
+ photoadjust (36126)
+ pt_assistant (2.1.15-19-g9aeec3c-SNAPSHOT)
+ reverter (36126)
+ scripting (v0.3.0)
+ utilsplugin2 (36134)
+ wikipedia (605)
Tagging presets:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/FR.zip
Map paint styles:
- ${HOME}/Downloads/Styles_ColourGPSData-style.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NumberedWalkingNodeNetworks&zip=1
+ ${HOME}/Downloads/Guidepost.mapcss
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR_OC.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/NumberedCycleNodeNetworks&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/NumberedWalkingNodeNetworks&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
Last errors/warnings:
- 03671.599 W: Unsaved changes - <html>You have unsaved changes in this editor window.<br><br>Do you want to discard these changes and reload data from layer?</html>
- 08175.317 W: JCS - Silent failure during download: https://tms.cadastre.openstreetmap.fr/*/tout/21/1063339/725466.png
- 08184.616 W: JCS - Silent failure during download: https://tms.cadastre.openstreetmap.fr/*/tout/21/1063342/725467.png
- 08188.038 W: JCS - Silent failure during download: https://tms.cadastre.openstreetmap.fr/*/tout/21/1063343/725465.png
- 08188.395 W: JCS - Silent failure during download: https://tms.cadastre.openstreetmap.fr/*/tout/21/1063342/725469.png
- 08195.256 W: JCS - Silent failure during download: https://tms.cadastre.openstreetmap.fr/*/tout/21/1063346/725467.png
- 08211.407 W: JCS - Silent failure during download: https://tms.cadastre.openstreetmap.fr/*/tout/20/531672/362734.png
- 09982.351 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 10039.224 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 10039.300 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
Attachments (0)
Change History (4)
comment:1 by , 2 years ago
comment:2 by , 2 years ago
Looks like the source is https://www.wikidata.org/wiki/Property:P18#P1282 .
I have no clue if that is expected for standard wikidata; it looks like they were added back on 2022-07-24.
I don't think properties should be included in the generated data. But I don't edit wikidata a whole bunch, so it is outside my area of expertise.
comment:3 by , 2 years ago
Thank you very much Taylor for your search.
I explained the issue and fix properties.
Could you update data please ?
Note: I didn't delete these keys but use the rank obsolete. Please verify that your query exclude keys with this rank.
comment:4 by , 2 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Looks good from here. I'll wait for the next automatic update though. Poke me sometime after the 21st so I can remember to update the tag2link dependency.
Note:
See TracTickets
for help on using tickets.
I just refreshed the source files; something has a
P1282property withKey:mapillarybesides the mapillary wikidata page. I'll see if I can get the Q id for the item into a debug file or something.