Modify ↓

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#23256 closed defect (fixed)

[PATCH] AbstractPrimitive::putAll not updating values

Reported by: marcello@… Owned by: team
Priority: critical Milestone: 23.11
Component: Core Version:
Keywords: Cc:

Description

AbstractPrimitive::putAll only works if some key is added. A putAll that only replaces values on existing keys does nothing at all.

Critical because you may lose data updates.

Attachments (1)

23256.patch​ (2.7 KB ) - added by marcello@… 10 months ago.
test and patch

Download all attachments as: .zip

Change History (6)

by marcello@…, 10 months ago

Attachment: 23256.patch​ added

test and patch

comment:1 by marcello@…, 10 months ago

Summary: AbstractPrimitive::putAll not updating values → [PATCH] AbstractPrimitive::putAll not updating values

comment:2 by taylor.smock, 10 months ago

Milestone: → 23.10

Thank you for the patch. I'm surprised no one noticed this before now -- the code has been there since 2022-06-08.

comment:3 by taylor.smock, 10 months ago

Resolution: → fixed
Status: new → closed

In 18890/josm:

Fix #23256: AbstractPrimitive::putAll not updating values (patch by marcello, modified)

Modifications are as follows:

  • Unit tests were split out into discrete units for better test feedback in the future.

comment:4 by taylor.smock, 10 months ago

In 18891/josm:

Fix #23256: AbstractPrimitive::putAll not updating values (patch by marcello)

comment:5 by taylor.smock, 10 months ago

Milestone: 23.10 → 23.11

Ticket retargeted after milestone deleted

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.