Oauth 2.0 token setup popunder blocks preferences dialog controls

[mirror176@…]

What steps will reproduce the problem?

1. Edit>Preferences...>OSM Server>Use Auth 2.0
2. Click to get a new access token
3. Accept through website
4. Returning to JOSM and click test which gives a popup that it succeeded
5. Clicking 'OK' on main preferences dialog got blocked by another popup that testing the token succeeded; pressed it successfully by tabbing to 'ok' and pressing enter which closed it and revealed the popunder.

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Was attempting to convert to 2.0 based on 'News>Upcoming Changes' on opening screen saying to switch to Oauth2.0.

Revision:18822
Build-Date:2023-08-30 11:44:32

Identification: JOSM/1.5 (18822 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 2009 (19045)
Memory Usage: 1040 MB / 8180 MB (282 MB allocated, but free)
Java version: 17.0.8+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18822, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]

Plugins:
+ AddrInterpolation (36134)
+ DirectUpload (36126)
+ ElevationProfile (36126)
+ FastDraw (36126)
+ FixAddresses (36126)
+ HouseNumberTaggingTool (36126)
+ ImproveOsm (238)
+ KartaView (413)
+ Mapillary (2.2.0)
+ MicrosoftStreetside (36126)
+ OpeningHoursEditor (36126)
+ RoadSigns (36126)
+ alignways (36126)
+ apache-commons (36034)
+ apache-http (35924)
+ areaselector (1652822522)
+ austriaaddresshelper (88)
+ buildings_tools (36134)
+ editgpx (36126)
+ ejml (35924)
+ fieldpapers (v0.5.0)
+ geochat (36149)
+ gridify (1606242219)
+ gson (35924)
+ imagery_offset_db (36126)
+ jackson (36034)
+ javafx (36118)
+ jna (36126)
+ junctionchecking (36126)
+ log4j (36045)
+ mapwithai (813)
+ measurement (36126)
+ pdfimport (36126)
+ pmtiles (36125)
+ print (36126)
+ tageditor (36126)
+ terracer (36126)
+ turnlanes-tagging (0.0.5)
+ turnrestrictions (36126)
+ utilsplugin2 (36134)

Tagging presets:
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/NewParkingFeatures&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Last errors/warnings:
- 00000.670 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.673 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00002.366 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 00049.771 E: Invalid setting (Icon missing): org.openstreetmap.josm.plugins.fixAddresses.FixAddressesPreferences

[taylor.smock]

Closed as duplicate of #16485.
This is really a problem with window order. There are some other windows that appear over modal ("blocking") dialogs. Sometimes users can get the modal dialog to appear via alt-tab or other window switching, but in other cases, the user has to move the top window such that they can see the modal dialog.

As a specific example, if you undock a toggle dialog (such as the Tags/Memberships), then open the Add tag dialog, then move the newly opened dialog to where the undocked toggle dialog is, you will experience roughly the same thing.

I don't know what causes this, and I have tried to debug this in the past. I suspect it is a problem in the JRE, but I haven't ever been able to pin it down.

Anyway, thank you for the bug report.