Modify

Opened 2 years ago

Closed 18 months ago

#23161 closed defect (duplicate)

Duplicate housenumber warning

Reported by: dieterdreist Owned by: dieterdreist
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: duplicate, housenumber Cc:

Description

Josm now warns about "duplicate housenumbers", but there is really nothing wrong with the same address belonging to several OSM objects, especially in areas where the housenumbers are assigned to points and not to areas, hence for the POIs it cannot be inherited from enclosing polygons.

Attachments (0)

Change History (14)

comment:1 by gaben, 2 years ago

Owner: changed from team to dieterdreist
Status: newneedinfo

Thanks for your report, however your ticket is incomplete and therefore not helpful in its current form.

Please add all needed information according to this list:

  • The required parts of the Status Report from your JOSM.
  • Describe what behaviour you expected.
  • Describe what did happen instead.
  • Describe if and how the issue is reproducible.
  • Add any relevant information like error messages or screenshots.

To ensure that all technical relevant information is contained, create new tickets by clicking in JOSMs Main Menu on Helpsource:trunk/resources/images/bug.svg Report Bug.

Remember: This is a generic notice so we don't need to write the same stuff again and again. It may only apply in parts to the specific case!


comment:2 by gaben, 2 years ago

Please add at least the version you are using and the expected behaviour.

To my knowledge, this validator rule is in the program for at least 4-5 years, therefore I don't get the "Josm now warns about" part.

comment:3 by dieterdreist, 2 years ago

Happens with Josm latest, version 18824. The expected behaviour is not seeing a problem where several things have the same address, it is very common and not a problem. Sorry for the "now", maybe I had this warning disabled before.

comment:4 by gaben, 2 years ago

I think the rule can be modified to ignore duplicates within an area if the area and inner nodes have the same value.

comment:5 by gaben, 2 years ago

Owner: changed from dieterdreist to team
Status: needinfonew

in reply to:  5 ; comment:6 by dieterdreist, 2 years ago

Replying to gaben:
It would be a start, but in Italy for example, housenumbers are often not tagged to areas but to points only, mostly entrances and gates, and on POIs. There isn't anything wrong with 2 POIs having the same address, also without the area.

in reply to:  6 comment:7 by zyphlar, 21 months ago

Replying to dieterdreist:

Could you provide a link to a few duplicate items that you've found which are detected as duplicates which don't need to be warned about?

comment:8 by skyper, 18 months ago

Owner: changed from team to dieterdreist
Status: newneedinfo

comment:9 by dieterdreist, 18 months ago

I can't reproduce. Even if there is a POI node with full address data and another node with the same full address data and no other tags (but part of a building outline, ideally should get an entrance=yes/no/main tag for clarification (in Italy)), there is no warning. I even tried with a "factory reset" because I thought I may have disabled the warning, but nothing

Last edited 18 months ago by dieterdreist (previous) (diff)

comment:10 by skyper, 18 months ago

Take a look at the new preference Include POIs like amenities, offices, and buildings in duplicate address detection which was added in r18922. Along side the severity was lowered and you need to enable informational warnings, see #23302.

comment:11 by dieterdreist, 18 months ago

ok, great, thank you, this works for me. It may be worth an informal warning for people who would like to see it, as long as it isn't active by default this is fine for me.

comment:12 by stoecker, 18 months ago

Resolution: fixed
Status: needinfoclosed

comment:13 by skyper, 18 months ago

Resolution: fixed
Status: closedreopened

comment:14 by skyper, 18 months ago

Resolution: duplicate
Status: reopenedclosed

Closed as duplicate of #23302.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain dieterdreist.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.