Opened 3 years ago
Last modified 3 years ago
#23114 closed enhancement
[PATCH] Add module-info to JMapViewer — at Version 1
| Reported by: | taylor.smock | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | JMapViewer | Version: | |
| Keywords: | Don-vip, stoecker | Cc: |
Description (last modified by )
I'd like to add a module-info to JMapViewer before we do another release of it.
The patch does the following:
- Adds a
module-info.javaclass that exports everything and requiresjava.desktopandjava.logging. - Modify the
build.xmlfile to build themodule-info.classfile if built under Java 9. This does require two compile runs, soant buildtakes a bit longer (2s). In order to get the secondjavacto work, I had to delete the compiled files (except formodule-info.class). While I could technically just compilemodule-infoby itself, that removes the compile-time sanity checks for modules.
EDIT: Let me know if we don't want a module-info in JMapViewer.
Change History (2)
by , 3 years ago
| Attachment: | 23114.patch added |
|---|
comment:1 by , 3 years ago
| Description: | modified (diff) |
|---|---|
| Type: | defect → enhancement |
Note:
See TracTickets
for help on using tickets.


