Modify

Opened 2 years ago

Closed 2 years ago

#23113 closed defect (fixed)

[PATCH] Add default methods to JMapViewer TileSource interface

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 23.12
Component: Core Version:
Keywords: java8 Cc:

Description

As noted elsewhere, there are some methods in JMapViewer that would benefit from having default methods. For the most part, these are overloads that take an object and then (generally) use fields from that object by calling a more specific method.

This could also be done for MapMarker, but getting implementors to cache getCoordinate is probably a good idea.

Attachments (3)

23113.jmapviewer.patch (7.8 KB ) - added by taylor.smock 2 years ago.
23113.core.patch (4.0 KB ) - added by taylor.smock 2 years ago.
23113.pmtiles.patch (1.8 KB ) - added by taylor.smock 2 years ago.

Download all attachments as: .zip

Change History (11)

by taylor.smock, 2 years ago

Attachment: 23113.jmapviewer.patch added

by taylor.smock, 2 years ago

Attachment: 23113.core.patch added

by taylor.smock, 2 years ago

Attachment: 23113.pmtiles.patch added

comment:1 by taylor.smock, 2 years ago

Milestone: 23.09

comment:2 by taylor.smock, 2 years ago

Resolution: fixed
Status: newclosed

In 36138/osm:

Fix #23113: Add default methods to JMapViewer TileSource interface

comment:3 by taylor.smock, 2 years ago

Component: JMapViewerCore
Milestone: 23.0923.10
Resolution: fixed
Status: closedreopened

Now we just need to do a release of JMapViewer.

comment:4 by taylor.smock, 2 years ago

In 36141/osm:

Release v2.17: See #19064, #23113, #23114

  • #19064: Resolve tools and libraries using Apache Ivy
  • #23113: Add default methods to JMapViewer TileSource interface
  • #23114: Add module-info to JMapViewer

comment:5 by taylor.smock, 2 years ago

Milestone: 23.1023.11

Ticket retargeted after milestone deleted

comment:6 by taylor.smock, 2 years ago

Milestone: 23.11

Ticket retargeted after milestone closed

comment:7 by taylor.smock, 2 years ago

Milestone: 23.12

comment:8 by taylor.smock, 2 years ago

Resolution: fixed
Status: reopenedclosed

In 18911/josm:

Fix #23113: Use default methods from JMapViewer

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.