Modify ↓

Opened 2 years ago

Closed 2 years ago

#23110 closed enhancement (fixed)

[PATCH] Add cash_in=* to amenity=atm

Reported by: pos513 Owned by: team
Priority: normal Milestone: 23.08
Component: Internal preset Version:
Keywords: Cc:

Description (last modified by pos513)

Key cash_in=* allows to specify whether amenity=atm allows depositing of cash.

Documentation: ​osmwiki:Key:cash_in
As of today (2023-08-09), there are more than 20k ATMs with this key: ​https://taginfo.openstreetmap.org/keys/cash_in

Maybe also a checkbox for cash_in:coins=* could be considered, but as least in my part of the world, ATMs that allow to deposit coins are rare.

Attachments (0)

Change History (3)

comment:1 by pos513, 2 years ago

Description: modified (diff)

comment:2 by taylor.smock, 2 years ago

Milestone: → 23.08
Summary: Add cash_in=* to amenity=atm → [PATCH] Add cash_in=* to amenity=atm

This is a fairly easy one to fix. It doesn't look like the wiki page has changed dramatically in six months anyway. I don't know about adding cash_in:coins though -- there are only 2 uses.

  • resources/data/defaultpresets.xml 

    IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
diff --git a/resources/data/defaultpresets.xml b/resources/data/defaultpresets.xml
    a b  
    75947594            <text key="brand" text="Brand" />
    75957595            <text key="operator" text="Operator" />
    75967596            <reference ref="oh_wheelchair" />
     7597            <combo key="cash_in" text="Allows cash deposits" values="yes,no,customers" editable="false"/>
     7598            <combo key="cash_in:coins" text="Allows cash deposits" values="yes,no" editable="false"/> <!-- TODO only 2 uses, probably don't add for now -->
    75977599        </item> <!-- Automated Teller Machine -->
    75987600        <item name="Pawnbroker" icon="presets/shop/pawnbroker.svg" type="node,closedway,multipolygon" preset_name_label="true">
    75997601            <link wiki="Tag:shop=pawnbroker" />

  • resources/data/tagging-preset.xsd 

    IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
diff --git a/resources/data/tagging-preset.xsd b/resources/data/tagging-preset.xsd
    a b  
    407407        <attribute name="editable" type="boolean">
    408408            <annotation>
    409409                <documentation>
    410                     The combo box is read only, which means that the user can only select an item in the list. Default is "true", which means, the user can add other values as text. Feature is broken, see #6157.
     410                    The combo box is read only, which means that the user can only select an item in the list. Default is "true", which means, the user can add other values as text.
    411411                </documentation>
    412412            </annotation>
    413413        </attribute>
Last edited 2 years ago by taylor.smock (previous) (diff)

comment:3 by taylor.smock, 2 years ago

Resolution: → fixed
Status: new → closed

In 18812/josm:

Fix #23110: Add cash_in to amenity=atm

This also ignores some tags.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.