The last toggled map paint style is toggled on its own when clicking the map

[pluton]

What steps will reproduce the problem?

1. Disable a map style.
2. Open the image viewer with y.
3. Click the map.

What is the expected result?

The map style is disabled.

What happens instead?

The map style gets enabled on its own.

Please provide any additional information below. Attach a screenshot if possible.

A more general bug here is that sometimes after toggling styles, the last toggled one is toggled back when I click the map. It used to happen ~30% of the time (I used to use the mac os x theme then; maybe it's related), and now it's ~5% of the time recently. I stumbled upon the steps to reproduce above accidentally, and they are very likely related to this occasional bug.

This doesn't happen if the Map Paint Style window is undocked.

Revision:18772
Build-Date:2023-07-07 10:07:24

Identification: JOSM/1.5 (18772 en) Mac OS X 12.6.7
OS Build number: macOS 12.6.7 (21G651)
Memory Usage: 2812 MB / 4096 MB (469 MB allocated, but free)
Java version: 17.0.7+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: Display 69733248 1680×1050 (scaling 2.00×2.00)
Maximum Screen Size: 1680×1050
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=18772, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=/Applications/JOSM.app/Contents/MacOS/JOSM]
Dataset consistency test: No problems found

Plugins:
+ CustomizePublicTransportStop (36097)
+ FastDraw (36097)
+ ImproveOsm (238)
+ ImproveWay (32)
+ Mapillary (2.1.5)
+ apache-commons (36034)
+ apache-http (35924)
+ buildings_tools (36097)
+ comfort0 (35976)
+ easypresets (1623509627)
+ intersection (0.0.7)
+ javafx (36086)
+ jna (36005)
+ pt_assistant (2.1.15-19-g9aeec3c-SNAPSHOT)
+ reltoolbox (36103)
+ reverter (36066)
+ tageditor (36097)
+ terracer (36079)
+ todo (128)
+ turnlanes-tagging (0.0.5)
+ turnrestrictions (36097)
+ undelete (36066)
+ utilsplugin2 (36097)
+ waydownloader (36097)
+ wikipedia (605)

Tagging presets:
+ <josm.userdata>/EasyPresets.xml
+ <josm.userdata>/custom/presets.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/CommonKeyboardShortcuts&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
+ https://github.com/osmlab/appledata/archive/josm_paint_inline_validation.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/FixmeAndNote&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NewParkingFeatures&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1
+ <josm.userdata>/custom/notes.mapcss
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR_OR.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/Bench&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Incline&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Direction&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PriorityRoad&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Kerbs&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/RecyclingMaterials&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Highway_Nodes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- <josm.userdata>/custom/railroad.mapcss

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/UkrainePhoneNumbers&zip=1
- https://raw.githubusercontent.com/mellangr/ukrainian-streets-and-addresses-validator/main/uk_street_names_and_addresses_rules.mapcss
+ https://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1
- https://josm.openstreetmap.de/josmfile?page=Rules/SourceObjectTag&zip=1

Last errors/warnings:
- 00040.430 E: Failed to locate image '[[Image(pond.png)]]'
- 00040.707 E: Failed to locate image '[[Image(oil-palm.png)]]'

[pluton]

Video reproducing the bug