Modify

#23046 closed defect (duplicate)

Validator should check only updated data on upload

Reported by: ratrun Owned by: team
Priority: normal Milestone:
Component: Core validator Version: tested
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Load OSM data of an area A for which the validator creates a warning
  2. Load OSM data of an area B
  3. Make a "good" change in area B which does not trigger the validator to create errors/warnings
  4. Try to upload the change

What is the expected result?

No warning from the validator on upload

What happens instead?

A warning is displayed on upload

This problem was introduced with the fix for #9446.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-07-06 21:00:41 +0200 (Thu, 06 Jul 2023)
Revision:18772
Build-Date:2023-07-07 01:30:58
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18772 de) Linux Mint 21.1
Memory Usage: 344 MB / 1976 MB (73 MB allocated, but free)
Java version: 17.0.7+7-Ubuntu-0ubuntu122.04.2, Private Build, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1200 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: de_AT.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: de_AT
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: X-Cinnamon
Java package: openjdk-17-jre:amd64-17.0.7+7~us1-0ubuntu1~22.04.2
fonts-noto: fonts-noto:all-20201225-1build1
VM arguments: [--module-path=/usr/share/openjfx/lib, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, -Djosm.restart=true, -Djava.net.useSystemProxies=true, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED]
Dataset consistency test: No problems found

Plugins:
+ reverter (36066)

Attachments (1)

reproduce.osm.tar.gz (470.1 KB ) - added by ratrun 22 months ago.

Download all attachments as: .zip

Change History (7)

by ratrun, 22 months ago

Attachment: reproduce.osm.tar.gz added

comment:1 by anonymous, 22 months ago

I attached a compressed OSM file with which the problem can be reproduced. Just load it and try to upload the minimal change in area B. The warning in area A gets displayed.

comment:2 by SekeRob, 22 months ago

Was about to. Loaded a larger area and get hundreds of "way end node near other highway" during validation planning to upload the edits and started looking how to disable that in the prefs validation options. There isn't. Only want alerts on items I've modified and are linked to the modified item such as a bus route relation with a gap.

This started to appear with upgrading to 18772.

Last edited 22 months ago by SekeRob (previous) (diff)

comment:3 by gaben, 22 months ago

Ticket #23047 has been marked as a duplicate of this ticket.

comment:4 by gaben, 22 months ago

Summary: Validator should ceck only updated data on uploadValidator should check only updated data on upload

fix typo in title

comment:5 by gaben, 22 months ago

By default, the info level warnings are disabled and such cases resulting an empty list. Should be easy to fix.

Until then, you can enable these warnings to give the window meaning :)

comment:6 by taylor.smock, 22 months ago

Resolution: duplicate
Status: newclosed

Closed as duplicate of #23049.
I fixed this in r18775. I was not planning on doing a hotfix release, but I have seen 3 or 4 duplicates, so it might be worthwhile.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.